Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1] Dropdown improvements fix #2254

Closed
gibbsfromncis opened this issue Dec 3, 2018 · 1 comment
Closed

[1] Dropdown improvements fix #2254

gibbsfromncis opened this issue Dec 3, 2018 · 1 comment
Assignees
@gibbsfromncis
Labels
[1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [2] Verified Issue has been verified by a team member [3] Refactoring Classification indicating a change to code refactoring. [4b] Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform [5b] Small Indicates size of task. Est. between one and two hours [6] Style Guide Impact flag identifying related to a Style Guide [7] Finalized Administartion flag, notifies hours are finalized
Milestone
181219

Comments

@gibbsfromncis
Copy link
Contributor

Based on this comment #2149 (comment) to issue #2149 I need to fix it in the proper way
@gibbsfromncis gibbsfromncis self-assigned this Dec 3, 2018
@gibbsfromncis gibbsfromncis added this to the 181212 milestone Dec 3, 2018
@gibbsfromncis gibbsfromncis added [1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [5b] Small Indicates size of task. Est. between one and two hours [4b] Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform [2] Verified Issue has been verified by a team member [3] Refactoring Classification indicating a change to code refactoring. [6] Style Guide Impact flag identifying related to a Style Guide labels Dec 3, 2018
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 10, 2018
@gibbsfromncis
bitshares#2254 Update style-guide version to the latest
6924ed6
@gibbsfromncis gibbsfromncis mentioned this issue Dec 10, 2018
Merged
@gibbsfromncis
Copy link
Contributor Author

@startailcoon estimate: 1h

@sschiessl-bcp sschiessl-bcp mentioned this issue Dec 12, 2018
Closed
sschiessl-bcp pushed a commit that referenced this issue Dec 12, 2018
Merge pull request #2308 from gibbsfromncis/2254-dropdown-improvements
53c451e 
#2254 Dropdown improvements
@startailcoon startailcoon changed the title Dropdown improvements fix [1] Dropdown improvements fix Dec 12, 2018
@startailcoon startailcoon added the [7] Finalized Administartion flag, notifies hours are finalized label Dec 12, 2018
manikey123 added a commit to manikey123/bitshares-ui that referenced this issue Dec 23, 2018
@manikey123
update bts ui code 12/22 (#4)
e4bf2ed 
* ANT AssetSelector replacement: add AssetInput and AssetSelect

* AssetInput: don't show as invalid when there is no input

* bug fix initialization on private testnets.

* Implement Collateral Bid
- New operations descriptions
- New bid collateral form
- New collateral bids table

New AssetActions
- bidCollateral()

FormattedPrice Updated
- negative_invert for price with a negative invert factor

* Fixes

* Fixes

* Fixes

* 2084 issue fix v3

* When this.props.result is undefine, give default value to resultCode&quoteAmount

* When this.props.result is undefine, give default value to resultCode&quoteAmount

* Sort by Issuer name

* update

* - included display of included bids and refined text

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* default sort is price

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* fix collateral valuation

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* fix implicit type covnversion

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* bitshares#2135 Update style-guide version. Add steps component support

* refine text for bidding

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* enhance error handling of node (url not found)

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* enhance error handling of node (url not found)

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* Closes bitshares#1826

- allow AccessSettings to be rendered without a connected node
- balance can have undefiend entries

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* remove unused import

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* add new scam account

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* Enable EOS.* assets on withdraw

* Fixes renderCollateralBid() issue

* Closes bitshares#2267
Closes bitshares#2265

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* update bitsharesjs and other packages

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* update lock

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* refine asset_settle_instant

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* sync package lock

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* sync language files

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* add direct debit and timed transfer

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* add tooltip for borrow

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* undo changes, only formatting

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* add changes after reformatting

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* disable spotlights without account

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* Adding API server of ioBanker

* update locales

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* add tooltips, closes bitshares#2270

* add snap release and token

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* switch to bitshares-ui-automation build

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* move snap token script

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* add execute permission

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* adjust snap token setting again

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* add pr template

Signed-off-by: Stefan Schießl <stefan.schiessl@blockchainprojectsbv.com>

* Disable Margin Trading Link on Dashboard for GS Asset
Various code cleaning

* Apply bit to bitAssets on Borrow Link

* Fix Legacy WithdrawDeposit
- BlockTrades input/output coin pair failure fixed
- Disabled Winex, Citadel due to CORS issues crashing client

* Fix EOS OL deposit gateway selection and address generation.

* bitshares#2101 Update style-guide version to the latest

* added new coins

* bitshares#2207 Update style-guide version to the latest

* bitshares#2254 Update style-guide version to the latest

* Update locale-zh.json

fix asset_create translate error

* adjusted text

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* - remove node.btscharts.com (operator request)
- refine min_deposit_warning_asset text

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* add voting shortcut

* bitshares#2314 Remove ant inputs overrides on exchange

* bitshares#1997 Update registration selector buttons regarding style-guide

* bitshares#1997 Update Login selector regarding style-guide

* bitshares#1997 Replace old components to style-guide. Remove unused code (password hide/show). Add Account Input for account name typing based on style-guide input

* bitshares#1997 Replace old components to style-guide. Keep error reporting consistent (display error on input instead of notification)

* bitshares#1997 Update registration cloud account to style-guide components

* bitshares#1997 Update form type for cloud wallet form

* bitshares#1997 Fix locale

* bitshares#1997 Update wallet registration to style-guide components

* bitshares#1997 Fix form html tag duplicate and add check for ref to exist

* bitshares#1997 Fix padding for textarea

* Catch empty Market history data

* Fix paperwallet naming
Adding private to private key wallet by default.

* Add prop "ignorePriceFeed" to FormattedPrice

* Settle Modal fixes
- Use all funds by clicking on label
- Disallow more than account holds
- Tooltip on disable
- Reset form on asset change

* Adds the word TESTNET to footer when using a testnet node

* Updating README and CONTRIBUTING files

* Fixes currentAccount is in np not np.props

* Disable margin update for GS assets on Margin Positions section

* Enables the enter key for login and confirm modals

* Return missing styles back

* Catch invalid SettlePrice object

* Update permission_utils.js

when fullAccount is 'undefined',`new this.AccountPermission(fullAccount, null, type)` will throw an error  and cause page broken.  here add `if (!fullAccount) return`  to fix this error.

* Update+Add

[Update]: "Silicone Valley" edited to be "Silicon Valley"
[Add]: wss://singapore.bitshares.apasia.tech/ws

* refine wording and componentWillReceiveProps for SettleModal

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* add new scam account

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* update PR template

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* Changes the testnet check

* re-adding bitshares#2345, evaluating winex

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* - refactor footer a bit
- only show accesssettings tooltip when accesssettingpopover not shown

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* sync language files

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* add remove-english-locale-duplicates

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* refine solution to a redirect

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* correct spelling of bridge

* correct spelling of bridge

* correct spelling of bridge

* correct spelling of bridge

* correct spelling of bridge

* correct spelling of bridge

* correct spelling of bridge

* correct spelling of bridge

* correct spelling of bridge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gibbsfromncis gibbsfromncis

Labels
[1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [2] Verified Issue has been verified by a team member [3] Refactoring Classification indicating a change to code refactoring. [4b] Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform [5b] Small Indicates size of task. Est. between one and two hours [6] Style Guide Impact flag identifying related to a Style Guide [7] Finalized Administartion flag, notifies hours are finalized
Projects
None yet
Milestone
181219
Development

No branches or pull requests
2 participants
@startailcoon @gibbsfromncis