Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14][gibbsfromncis] New Sign Up/Login style-guide integration #1997

Closed
gibbsfromncis opened this issue Oct 13, 2018 · 6 comments · Fixed by #2210
Closed

[14][gibbsfromncis] New Sign Up/Login style-guide integration #1997

gibbsfromncis opened this issue Oct 13, 2018 · 6 comments · Fixed by #2210
Assignees
@gibbsfromncis
Labels
[1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive [5c] Medium Indicates size of task. Est. between two and four hours [7] Finalized Administartion flag, notifies hours are finalized
Milestone
181219

Comments

@gibbsfromncis
Copy link
Contributor

This is task was a part of #1832 but moved to separate task
@gibbsfromncis gibbsfromncis added [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [5c] Medium Indicates size of task. Est. between two and four hours labels Oct 13, 2018
@gibbsfromncis gibbsfromncis self-assigned this Oct 13, 2018
@gibbsfromncis gibbsfromncis changed the title [3][gibbsfromncis] New Sign Up Anityfing [2][gibbsfromncis] New Sign Up Anityfing Oct 15, 2018
@gibbsfromncis gibbsfromncis mentioned this issue Oct 25, 2018
Closed
@gibbsfromncis gibbsfromncis changed the title [2][gibbsfromncis] New Sign Up Anityfing [2][gibbsfromncis] New Sign Up/Login style-guide integration Oct 26, 2018
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Nov 24, 2018
@gibbsfromncis
bitshares#1997 Update registration selector buttons regarding style-g…
fe7774b 
…uide
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Nov 24, 2018
@gibbsfromncis
bitshares#1997 Update Login selector regarding style-guide
b968f54
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Nov 24, 2018
@gibbsfromncis
bitshares#1997 Replace old components to style-guide. Remove unused c…
572b31c 
…ode (password hide/show). Add Account Input for account name typing based on style-guide input
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Nov 24, 2018
@gibbsfromncis
bitshares#1997 Replace old components to style-guide. Keep error repo…
5e1f6e6 
…rting consistent (display error on input instead of notification)
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Nov 24, 2018
@gibbsfromncis
bitshares#1997 Update registration cloud account to style-guide compo…
334afec 
…nents
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Nov 24, 2018
@gibbsfromncis
bitshares#1997 Update form type for cloud wallet form
224152e
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Nov 24, 2018
@gibbsfromncis
bitshares#1997 Fix locale
1397265
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Nov 24, 2018
@gibbsfromncis
bitshares#1997 Update wallet registration to style-guide components
1de739a
@gibbsfromncis
Copy link
Contributor Author

Login Selector

screenshot 2018-11-24 05 03 59

screenshot 2018-11-24 05 03 57

Registration Selector

screenshot 2018-11-24 05 04 29

Registration (Cloud)

screenshot 2018-11-24 05 05 01

screenshot 2018-11-24 05 05 23

screenshot 2018-11-24 05 06 26

Registration (Local Wallet)

screenshot 2018-11-24 05 07 14

screenshot 2018-11-24 05 08 13

screenshot 2018-11-24 05 08 07

@gibbsfromncis
Copy link
Contributor Author

@startailcoon final estimate: 11h

@gibbsfromncis gibbsfromncis mentioned this issue Nov 24, 2018
Merged
@startailcoon startailcoon added this to the 181128 milestone Nov 24, 2018
@startailcoon startailcoon changed the title [2][gibbsfromncis] New Sign Up/Login style-guide integration [11][gibbsfromncis] New Sign Up/Login style-guide integration Nov 24, 2018
@startailcoon startailcoon added the [7] Finalized Administartion flag, notifies hours are finalized label Nov 24, 2018
@startailcoon
Copy link
Contributor

Great work as always!

@wmbutler wmbutler closed this as completed Dec 1, 2018
@sschiessl-bcp
Copy link
Contributor

The PR for this is still open ... looking at it now

@sschiessl-bcp sschiessl-bcp reopened this Dec 3, 2018
@gibbsfromncis gibbsfromncis modified the milestones: 181128, 181212 Dec 4, 2018
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 4, 2018
@gibbsfromncis
bitshares#1997 Fix form html tag duplicate and add check for ref to e…
4ba4985 
…xist
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 10, 2018
@gibbsfromncis
bitshares#1997 Update style-guide version to the latest
c81849b
@gibbsfromncis
Copy link
Contributor Author

gibbsfromncis commented Dec 10, 2018 •
edited
Loading

@startailcoon I had problems with my PR so I would like to ask you to add 3 additional hours (update to 14 hours instead of 11)

gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 12, 2018
@gibbsfromncis
bitshares#1997 Update registration selector buttons regarding style-g…
c38589d 
…uide
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 12, 2018
@gibbsfromncis
bitshares#1997 Update Login selector regarding style-guide
933cfdc
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 12, 2018
@gibbsfromncis
bitshares#1997 Replace old components to style-guide. Remove unused c…
d148cb9 
…ode (password hide/show). Add Account Input for account name typing based on style-guide input
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 12, 2018
@gibbsfromncis
bitshares#1997 Replace old components to style-guide. Keep error repo…
c1e7731 
…rting consistent (display error on input instead of notification)
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 12, 2018
@gibbsfromncis
bitshares#1997 Update registration cloud account to style-guide compo…
4a33e53 
…nents
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 12, 2018
@gibbsfromncis
bitshares#1997 Update form type for cloud wallet form
0ed8623
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 12, 2018
@gibbsfromncis
bitshares#1997 Fix locale
d69c12a
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 12, 2018
@gibbsfromncis
bitshares#1997 Update wallet registration to style-guide components
100e502
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 12, 2018
@gibbsfromncis
bitshares#1997 Fix form html tag duplicate and add check for ref to e…
e0cc2c5 
…xist
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 12, 2018
@gibbsfromncis
bitshares#1997 Update style-guide version to the latest
6f2316f
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 12, 2018
@gibbsfromncis
bitshares#1997 Fix padding for textarea
a1792c4
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 12, 2018
@gibbsfromncis
bitshares#1997 Fix style-guide to latest version
87838fc
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 12, 2018
@gibbsfromncis
bitshares#1997 Update registration selector buttons regarding style-g…
99c70ed 
…uide
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 12, 2018
@gibbsfromncis
bitshares#1997 Update Login selector regarding style-guide
3b77740
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 12, 2018
@gibbsfromncis
bitshares#1997 Replace old components to style-guide. Remove unused c…
090b2af 
…ode (password hide/show). Add Account Input for account name typing based on style-guide input
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 12, 2018
@gibbsfromncis
bitshares#1997 Replace old components to style-guide. Keep error repo…
c700cac 
…rting consistent (display error on input instead of notification)
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 12, 2018
@gibbsfromncis
bitshares#1997 Update registration cloud account to style-guide compo…
5f9c405 
…nents
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 12, 2018
@gibbsfromncis
bitshares#1997 Update form type for cloud wallet form
f134167
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 12, 2018
@gibbsfromncis
bitshares#1997 Fix locale
0023f3b
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 12, 2018
@gibbsfromncis
bitshares#1997 Update wallet registration to style-guide components
b2cb142
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 12, 2018
@gibbsfromncis
bitshares#1997 Fix form html tag duplicate and add check for ref to e…
f237ea5 
…xist
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 12, 2018
@gibbsfromncis
bitshares#1997 Fix padding for textarea
dcb6b94
sschiessl-bcp pushed a commit that referenced this issue Dec 12, 2018
Merge pull request #2210 from gibbsfromncis/1997-new-singup-styling
72dee05 
#1997 New Sign In / Sign Up styling
manikey123 added a commit to manikey123/bitshares-ui that referenced this issue Dec 23, 2018
@manikey123
update bts ui code 12/22 (#4)
e4bf2ed 
* ANT AssetSelector replacement: add AssetInput and AssetSelect

* AssetInput: don't show as invalid when there is no input

* bug fix initialization on private testnets.

* Implement Collateral Bid
- New operations descriptions
- New bid collateral form
- New collateral bids table

New AssetActions
- bidCollateral()

FormattedPrice Updated
- negative_invert for price with a negative invert factor

* Fixes

* Fixes

* Fixes

* 2084 issue fix v3

* When this.props.result is undefine, give default value to resultCode&quoteAmount

* When this.props.result is undefine, give default value to resultCode&quoteAmount

* Sort by Issuer name

* update

* - included display of included bids and refined text

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* default sort is price

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* fix collateral valuation

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* fix implicit type covnversion

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* bitshares#2135 Update style-guide version. Add steps component support

* refine text for bidding

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* enhance error handling of node (url not found)

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* enhance error handling of node (url not found)

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* Closes bitshares#1826

- allow AccessSettings to be rendered without a connected node
- balance can have undefiend entries

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* remove unused import

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* add new scam account

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* Enable EOS.* assets on withdraw

* Fixes renderCollateralBid() issue

* Closes bitshares#2267
Closes bitshares#2265

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* update bitsharesjs and other packages

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* update lock

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* refine asset_settle_instant

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* sync package lock

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* sync language files

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* add direct debit and timed transfer

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* add tooltip for borrow

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* undo changes, only formatting

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* add changes after reformatting

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* disable spotlights without account

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* Adding API server of ioBanker

* update locales

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* add tooltips, closes bitshares#2270

* add snap release and token

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* switch to bitshares-ui-automation build

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* move snap token script

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* add execute permission

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* adjust snap token setting again

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* add pr template

Signed-off-by: Stefan Schießl <stefan.schiessl@blockchainprojectsbv.com>

* Disable Margin Trading Link on Dashboard for GS Asset
Various code cleaning

* Apply bit to bitAssets on Borrow Link

* Fix Legacy WithdrawDeposit
- BlockTrades input/output coin pair failure fixed
- Disabled Winex, Citadel due to CORS issues crashing client

* Fix EOS OL deposit gateway selection and address generation.

* bitshares#2101 Update style-guide version to the latest

* added new coins

* bitshares#2207 Update style-guide version to the latest

* bitshares#2254 Update style-guide version to the latest

* Update locale-zh.json

fix asset_create translate error

* adjusted text

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* - remove node.btscharts.com (operator request)
- refine min_deposit_warning_asset text

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* add voting shortcut

* bitshares#2314 Remove ant inputs overrides on exchange

* bitshares#1997 Update registration selector buttons regarding style-guide

* bitshares#1997 Update Login selector regarding style-guide

* bitshares#1997 Replace old components to style-guide. Remove unused code (password hide/show). Add Account Input for account name typing based on style-guide input

* bitshares#1997 Replace old components to style-guide. Keep error reporting consistent (display error on input instead of notification)

* bitshares#1997 Update registration cloud account to style-guide components

* bitshares#1997 Update form type for cloud wallet form

* bitshares#1997 Fix locale

* bitshares#1997 Update wallet registration to style-guide components

* bitshares#1997 Fix form html tag duplicate and add check for ref to exist

* bitshares#1997 Fix padding for textarea

* Catch empty Market history data

* Fix paperwallet naming
Adding private to private key wallet by default.

* Add prop "ignorePriceFeed" to FormattedPrice

* Settle Modal fixes
- Use all funds by clicking on label
- Disallow more than account holds
- Tooltip on disable
- Reset form on asset change

* Adds the word TESTNET to footer when using a testnet node

* Updating README and CONTRIBUTING files

* Fixes currentAccount is in np not np.props

* Disable margin update for GS assets on Margin Positions section

* Enables the enter key for login and confirm modals

* Return missing styles back

* Catch invalid SettlePrice object

* Update permission_utils.js

when fullAccount is 'undefined',`new this.AccountPermission(fullAccount, null, type)` will throw an error  and cause page broken.  here add `if (!fullAccount) return`  to fix this error.

* Update+Add

[Update]: "Silicone Valley" edited to be "Silicon Valley"
[Add]: wss://singapore.bitshares.apasia.tech/ws

* refine wording and componentWillReceiveProps for SettleModal

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* add new scam account

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* update PR template

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* Changes the testnet check

* re-adding bitshares#2345, evaluating winex

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* - refactor footer a bit
- only show accesssettings tooltip when accesssettingpopover not shown

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* sync language files

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* add remove-english-locale-duplicates

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* refine solution to a redirect

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>

* correct spelling of bridge

* correct spelling of bridge

* correct spelling of bridge

* correct spelling of bridge

* correct spelling of bridge

* correct spelling of bridge

* correct spelling of bridge

* correct spelling of bridge

* correct spelling of bridge
@gibbsfromncis gibbsfromncis changed the title [11][gibbsfromncis] New Sign Up/Login style-guide integration [14][gibbsfromncis] New Sign Up/Login style-guide integration Jan 3, 2019
@gibbsfromncis
Copy link
Contributor Author

Updated hours because of this comment: #1997 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gibbsfromncis gibbsfromncis

Labels
[1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive [5c] Medium Indicates size of task. Est. between two and four hours [7] Finalized Administartion flag, notifies hours are finalized
Projects
None yet
Milestone
181219
Development

Successfully merging a pull request may close this issue.

#1997 New Sign In / Sign Up styling gibbsfromncis/bitshares-ui
4 participants
@wmbutler @startailcoon @sschiessl-bcp @gibbsfromncis