[2] Dropdown Improvements

[startailcoon]

Issue extracted from #2020

By @wmbutler

The color of the selected item in the dropdown is a little ambiguous. I'd typically expect highest contrast to be the selected item but this is clearly not possible on the Midnight view. See this screenshot to illustrate my point. Maybe we use the blue universally? This is a tough one.

[startailcoon]

Here is a licecap that visualizes it a bit more

[gibbsfromncis]

@startailcoon to be honest I'm not following the idea... can you clarify please?

Do you mean that currently selected item has the same background as hovered items?

[sschiessl-bcp]

Please check that you can also select with keyboard (up and down moves the selection, enter confirms it)

[startailcoon]

@wmbutler, could you clarify your thoughts on this matter?

[wmbutler]

I'll claim this.

[wmbutler]

Here is my proposed change. I think what was most confusing was the hover color. Typically, I'd expect a higher contrast for the selected item. The midnight view makes higher contrast virtually impossible with a background color, so I updated the style guide to reflect only a blue color for active/hover states on the text menu items. I think it looks pretty good.

It took me two hours to hunt through all the variations.

[wmbutler]

bitshares/bitshares-ui-style-guide#4

[gibbsfromncis]

@wmbutler Unfortunately your changes will work but only till next update from my side, because you changed source file instead of config file which uses to build themes.

There is instruction how to update styles on the right way - https://github.com/bitshares/bitshares-ui-style-guide/blob/master/INSTRUCTIONS.md#how-to-manage-styles-of-style-guide-components-

I'll open new issue to fix it

[wmbutler]

Oops. Sorry. I'll review.

[wmbutler]

I just read your instructions and saw no mention of a config file.

[wmbutler]

Your instructions are a bit ambiguous. Every directory is /dark/ ?

[gibbsfromncis]

@wmbutler my bad.. Updated.

https://github.com/bitshares/bitshares-ui-style-guide/blob/master/INSTRUCTIONS.md

[gibbsfromncis]

@wmbutler There are few ways to get your task done.

1. Update specific ant's variable which is responsible for that.
2. If ant has no variable to handle your situation you should do the next:

• Provide your own variable for Select (ant calls it Select)
• Add override of Select for specific state you need

@wmbutler Lets make it more faster - give me color you need, I'll update it and we will keep your hours and I'll put my hours and we finally will close this task.

[gibbsfromncis]

@wmbutler this is how it should be updated:

1. Add specific variables for each 3 themes:
   bitshares/bitshares-ui-style-guide@a244b09#diff-0416afb78c680a498fad03bd9c360a87
   bitshares/bitshares-ui-style-guide@a244b09#diff-d0cdf296af98dee69ff46bdf7d34256c
   bitshares/bitshares-ui-style-guide@a244b09#diff-c2e6b709522384151775775a33686b4b

2. Add overrides for select (because select doesn't have its own variables for this kind of styling)

bitshares/bitshares-ui-style-guide@a244b09#diff-bd9e7d6072b9e6de78f2e08cd951e508