Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System Alerts #513

Merged
merged 5 commits into from
Aug 14, 2018
Merged

System Alerts #513

merged 5 commits into from
Aug 14, 2018

Conversation

amichard
Copy link
Contributor

#498 #499 #500 #501 #502 #503 #504 #505 #506 #507 #508 #509 #510 #511 #512

Implemented a toastr system to provide feedback to the user when they perform certain actions.

Changelog:

  • Installed Redux Toastr
  • Fixed an issue where a credit transfer initiated by a government user crashes when editing
  • Added highlighting of newly added/updated row
  • URL is rewritten when loading the Credit Transaction List page (this is to solve an issue I had with the highlight function)

@amichard amichard added this to the RELEASE v0.3.1 milestone Aug 14, 2018
@amichard amichard self-assigned this Aug 14, 2018
@amichard
Copy link
Contributor Author

System Alerts | Save a Draft Credit Transfer Proposal |5|

@amichard
Copy link
Contributor Author

System Alerts | Delete a Saved Draft of a Credit Transfer Proposal |1|

@amichard
Copy link
Contributor Author

System Alerts | Propose a Credit Transfer (Sign 1/2) |1|

@amichard
Copy link
Contributor Author

System Alerts | Accept a Credit Transfer Proposal (Sign 2/2) |1|

@amichard
Copy link
Contributor Author

System Alerts | Refuse a Credit Transfer Proposal |1|

@amichard
Copy link
Contributor Author

System Alerts | Rescind a Credit Transfer Proposal |1|

@amichard
Copy link
Contributor Author

System Alerts | Recommend Approval of a Credit Transfer Proposal |1|

@amichard
Copy link
Contributor Author

System Alerts | Not Recommend Approval of a Credit Transfer Proposal |1|

@amichard
Copy link
Contributor Author

System Alerts | Approve a Credit Transfer Proposal |1|

@amichard
Copy link
Contributor Author

System Alerts | Decline to Approve a Credit Transfer Proposal |1|

@amichard
Copy link
Contributor Author

System Alerts | Return PVR back to Gov't Analyst |1|

@amichard
Copy link
Contributor Author

System Alerts | Save a Draft PVR |1|

@amichard
Copy link
Contributor Author

System Alerts | Recommend Approval of a PVR |1|

@amichard
Copy link
Contributor Author

System Alerts | Decline to Approve a PVR |1|

@amichard
Copy link
Contributor Author

System Alerts | Approve a PVR |1|

plasticviking
plasticviking approved these changes Aug 14, 2018
View reviewed changes
Copy link
Contributor

@plasticviking plasticviking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Like the highlighting.

@kuanfandevops kuanfandevops merged commit 8fb49ca into bcgov:master Aug 14, 2018
@amichard amichard deleted the system-alerts branch August 16, 2018 21:50
kuanfandevops pushed a commit that referenced this pull request Sep 19, 2019
@amichard @kuanfandevops
System Alerts (#513)
1a5fae1 
Installed Redux Toastr
Fixed an issue where a credit transfer initiated by a government user crashes when editing
Added highlighting of newly added/updated row
URL is rewritten when loading the Credit Transaction List page (this is to solve an issue I had with the highlight function)
@justin-lepitzki justin-lepitzki mentioned this pull request Jul 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plasticviking plasticviking plasticviking approved these changes

Assignees

@amichard amichard

Labels
None yet
Projects
None yet
Milestone
RELEASE v0.3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@amichard @plasticviking @kuanfandevops