TFRS - Notification link for supplemental requested broken after creation of a draft supplemental report

[justin-lepitzki]

Describe the Bug
Compliance report not loading when trying to access the report through the notifications page. This bug only occurs when the IDIR user requests a supplemental report (status: Supplemental Requested) and the BCeID user has created a draft supplemental.

Expected Behaviour
Clicking on the notification link for a compliance report (e.g., "Compliance Report for 2022 Supplemental Requested") should take you to the latest version of the 2022 report (draft supplemental, if created; otherwise the submitted report)

Actual Behaviour
The report is not loading when the BCeID user clicks on the notifications link (within the notifications page). Again, this is a specific edge case that only occurs when the IDIR user has requested a supplemental report (status: Supplemental Requested) and the BCeID user has created a draft supplemental. The report is still accessible through the 'Compliance & Exclusion Reports' main page.

Implications
Report fails to load and is causing confusion for suppliers in trying to access their reports.

Steps To Reproduce
Steps to reproduce the behaviour:

• have a submitted compliance report
• BCeID user has in-app notifications turned on for 'Supplemental Requested'
• IDIR user requests supplemental report by clicking on the 'Request Supplemental' button within a submitted compliance report
• BCeID user navigates to the compliance report through the 'Compliance & Exclusion Reports' page and creates a draft supplemental report.
• BCeID user then goes to their in-app notifications and clicks on the link to the report from the in-app notification (i.e., "Compliance Report for YYYY Supplemental Requested").
• The report will fail to load and their will be errors in the inspect console.

Example Report in Test:

• Org: Fuel Test Company 1
• Compliance Report ID# 513 & 1037, where System Alerts #513 is the original report and Fuel Codes | Add natural gas-based gasoline to list of approved fuels table |0| #1037 is the draft supplemental

Screenshot of console error:

Screenshot of notifications page where the link to access is located:

[justin-lepitzki]

This may be a larger issue where the system is not redirecting to the latest version of a report when clicking on links that have URLs associated with a previous versions of a report.

Another example of a similar error of a report failing to load when using an older version URL, but in the dev environment: credit transaction ID# 1049 is a reduction of 6,169 credits from acceptance of a 2023 compliance report. When clicking on the transaction entry on the credit transactions page, the report fails to load. A supplemental report for 2023 has been created and submitted (ID# 1023). When the user clicks on the reduction transaction entry, the system tries to load the report (ID# 1020) but fails to redirect to the latest version of the report (ID# 1023); it gets stuck loading.

[prv-proton]

Hey team! Please add your planning poker estimate with Zenhub @AlexZorkin @jig-patel @prv-proton