Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map_based_prediction): extend prediction time for intersection merging #629

Closed

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Oct 11, 2023

Description

When ego vehicle made a brief stop before turning left/right around intersection, the vehicle speed is very low.
In that case more prediction time is needed to early detect collision while driving slowly in the intersection.

Related links

Tests performed

evaluator:

Notes for reviewers

Interface changes

none.

Effects on system behavior

none.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the feat/extend-prediction-time branch from b1b6f47 to 4f2adca Compare October 12, 2023 05:34
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will increase computation time and burden.
Are there any evaluation about this?

TomohitoAndo pushed a commit to TomohitoAndo/autoware_launch.awf that referenced this pull request Oct 20, 2023
…towarefoundation#629)

* feat(planning_launch): new lane change path generation parameters

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* rearrange parameters

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix parameter for stable result

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Preparing for autowarefoundation#652

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@soblin soblin closed this Nov 13, 2023
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
fix: suppress unintended permits at intersections
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
… vehicle voice to config (autowarefoundation#629)

* chore(diagnostic_graph_aggregator): add heartbeat of MOT and vehicle voice system to config

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add signage

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* update timeout

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
yuki-takagi-66 pushed a commit to tier4/autoware_launch that referenced this pull request Jul 8, 2024
… vehicle voice to config (autowarefoundation#629)

* chore(diagnostic_graph_aggregator): add heartbeat of MOT and vehicle voice system to config

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add signage

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* update timeout

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants