Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added temporary retrocompatibility to old perception data #7929

Merged
merged 3 commits into from
Jul 10, 2024
+9 −2

Merge branch 'main' into fix/disable_memory_check_perception

d1938d2
Select commit
Loading
Failed to load commit list.
Merged

fix: added temporary retrocompatibility to old perception data #7929

Merge branch 'main' into fix/disable_memory_check_perception
d1938d2
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jul 10, 2024 in 1m 5s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.02 (8.68 -> 8.66)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method filter.cpp: pointcloud_preprocessor::Filter::faster_input_indices_callback

Annotations

Check warning on line 428 in sensing/pointcloud_preprocessor/src/filter.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

pointcloud_preprocessor::Filter::faster_input_indices_callback increases in cyclomatic complexity from 12 to 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 1 in sensing/pointcloud_preprocessor/src/filter.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Overall Code Complexity 

The mean cyclomatic complexity increases from 4.38 to 4.46, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
View more details on CodeScene Delta Analysis