fix: added temporary retrocompatibility to old perception data #7929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
knzo25
requested review from
amc-nu,
badai-nguyen,
drwnz,
kyoichi-sugahara,
meliketanrikulu,
miursh,
vividf,
YoshiRi and
yukkysaito
as code owners
github-actions
bot
added
the
component:sensing
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
knzo25
added
the
tag:run-build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7929 +/- ##
==========================================
- Coverage 28.74% 28.73% -0.02%
==========================================
Files 1593 1595 +2
Lines 116848 116841 -7
Branches 50027 50011 -16
==========================================
- Hits 33586 33569 -17
- Misses 74221 74234 +13
+ Partials 9041 9038 -3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Shin-kyoto
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 18, 2024
Ariiees
pushed a commit
to Ariiees/autoware.universe
that referenced
this pull request
Jul 22, 2024
…arefoundation#7929) Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Shin-kyoto
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 24, 2024
Shin-kyoto
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 26, 2024
Shin-kyoto
added a commit
to Shin-kyoto/autoware.universe
that referenced
this pull request
Aug 7, 2024
Shin-kyoto
added a commit
to Shin-kyoto/autoware.universe
that referenced
this pull request
Aug 7, 2024
…patibility to old perception data (autowarefoundation#7929)" This reverts commit 6b9f164. Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
kminoda
pushed a commit
that referenced
this pull request
Aug 19, 2024
…patibility to old perception data (#7929)" (#8397) * feat!(pointcloud_preprocessor): Revert "fix: added temporary retrocompatibility to old perception data (#7929)" This reverts commit 6b9f164. Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com> * feat(pointcloud_preprocessor): minor grammar fix Co-authored-by: David Wong <33114676+drwnz@users.noreply.github.com> --------- Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com> Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> Co-authored-by: David Wong <33114676+drwnz@users.noreply.github.com>
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Aug 27, 2024
…patibility to old perception data (autowarefoundation#7929)" (autowarefoundation#8397) * feat!(pointcloud_preprocessor): Revert "fix: added temporary retrocompatibility to old perception data (autowarefoundation#7929)" This reverts commit 6b9f164. Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com> * feat(pointcloud_preprocessor): minor grammar fix Co-authored-by: David Wong <33114676+drwnz@users.noreply.github.com> --------- Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com> Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> Co-authored-by: David Wong <33114676+drwnz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of our code is still using data with the old pointcloud type. In this PR I add temporary retro-compatibility by disabling the related memory checks
Related links
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.