Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(static_drivable_area_expansion): fix invalid z-pos #6357

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Feb 8, 2024

Description

Fix invalid drivable area bound z-pos.
image

Tests performed

Psim
Screenshot from 2024-02-08 16-46-25

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 8, 2024
@satoshi-ota satoshi-ota added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 8, 2024
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk enabled auto-merge (squash) February 8, 2024 07:54
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (488fca5) 14.84% compared to head (8a53696) 14.85%.
Report is 3 commits behind head on main.

Files Patch % Lines
...s/drivable_area_expansion/static_drivable_area.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6357   +/-   ##
=======================================
  Coverage   14.84%   14.85%           
=======================================
  Files        1845     1845           
  Lines      126781   126773    -8     
  Branches    37961    37962    +1     
=======================================
  Hits        18826    18826           
+ Misses      86733    86725    -8     
  Partials    21222    21222           
Flag Coverage Δ *Carryforward flag
differential 11.38% <0.00%> (?)
total 14.85% <ø> (+<0.01%) ⬆️ Carriedforward from 488fca5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shmpwk shmpwk merged commit 4bb003d into autowarefoundation:main Feb 8, 2024
35 of 36 checks passed
@satoshi-ota satoshi-ota deleted the fix/z-pos branch February 8, 2024 09:21
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Feb 8, 2024
…ation#6357)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Feb 8, 2024
…ation#6357)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
shmpwk added a commit to tier4/autoware.universe that referenced this pull request Feb 8, 2024
fix(static_drivable_area_expansion): fix invalid z-pos (autowarefoundation#6357)
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Feb 23, 2024
…ation#6357)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Feb 23, 2024
…ation#6357)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jun 6, 2024
…ation#6357)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants