Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): check far objects during shifting #5857

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Dec 13, 2023

Description

🤖[deprecated] Generated by Copilot at c12bae9

Added a condition to helper.hpp to limit obstacle detection range when the vehicle is shifted. This improves the performance of the behavior path avoidance module.

Previously, avoidance behavior was unnatural and wavy. SInce detection area longitudinal distance is based on current ego speed, if the vehicle drives low speed avoidance module doesn't generate far objects. Then, avoidance module doesn't update return path until the vehicle gets closer.

simplescreenrecorder-2023-12-15_18.16.19.mp4

Tests performed

Psim

simplescreenrecorder-2023-12-15_18.04.37.mp4

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 13, 2023
@satoshi-ota satoshi-ota added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 15, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review December 15, 2023 03:37
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (f2cc50c) 15.35% compared to head (0f47c1e) 15.36%.
Report is 4 commits behind head on main.

Files Patch % Lines
.../include/behavior_path_avoidance_module/helper.hpp 28.57% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5857   +/-   ##
=======================================
  Coverage   15.35%   15.36%           
=======================================
  Files        1747     1747           
  Lines      120058   120050    -8     
  Branches    36539    36538    -1     
=======================================
+ Hits        18440    18441    +1     
+ Misses      80962    80950   -12     
- Partials    20656    20659    +3     
Flag Coverage Δ *Carryforward flag
differential 13.36% <28.57%> (?)
total 15.36% <ø> (+<0.01%) ⬆️ Carriedforward from f2cc50c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota enabled auto-merge (squash) December 15, 2023 09:44
@satoshi-ota satoshi-ota merged commit a5d5479 into autowarefoundation:main Dec 15, 2023
31 of 32 checks passed
@satoshi-ota satoshi-ota deleted the fix/check-far-object branch December 16, 2023 08:31
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…#5857)

* fix(avoidance): check far objects during shifting

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): update impl

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…#5857)

* fix(avoidance): check far objects during shifting

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): update impl

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…#5857)

* fix(avoidance): check far objects during shifting

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): update impl

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…#5857)

* fix(avoidance): check far objects during shifting

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): update impl

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…#5857)

* fix(avoidance): check far objects during shifting

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): update impl

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants