Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(occlusion_spot): boost::optional to std::optional #5832

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Dec 11, 2023

Description

🤖[deprecated] Generated by Copilot at 56a7913

Replaced boost::optional with std::optional in the behavior_velocity_occlusion_spot_module to reduce dependency on Boost and use standard C++17 features. This affects the functions and types related to occlusion and occupancy polygons in grid_utils.cpp, grid_utils.hpp, occlusion_spot_utils.cpp, and occlusion_spot_utils.hpp.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 11, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Dec 11, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (f41d3fa) 15.28% compared to head (56a7913) 15.28%.
Report is 3 commits behind head on main.

Files Patch % Lines
..._velocity_occlusion_spot_module/src/grid_utils.cpp 0.00% 5 Missing ⚠️
...occlusion_spot_module/src/occlusion_spot_utils.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5832   +/-   ##
=======================================
  Coverage   15.28%   15.28%           
=======================================
  Files        1739     1739           
  Lines      119756   119746   -10     
  Branches    36369    36363    -6     
=======================================
  Hits        18301    18301           
+ Misses      80976    80966   -10     
  Partials    20479    20479           
Flag Coverage Δ *Carryforward flag
differential 20.05% <0.00%> (?)
total 15.28% <ø> (+<0.01%) ⬆️ Carriedforward from f41d3fa

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 4a0c837 into autowarefoundation:main Dec 12, 2023
34 of 36 checks passed
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…oundation#5832)

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…oundation#5832)

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the refactor-occlusion-spot-boost-optional-to-std branch December 21, 2023 03:43
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants