fix(lidar_centerpoint,image_projection_based_fusion): add guard to avoid exceeding max voxel size #5824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
wep21
requested review from
knzo25,
yukke42,
badai-nguyen,
miursh,
YoshiRi and
yukkysaito
as code owners
github-actions
bot
added
the
component:perception
wep21
added
the
tag:run-build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5824 +/- ##
==========================================
- Coverage 15.28% 15.16% -0.12%
==========================================
Files 1739 1766 +27
Lines 119755 120687 +932
Branches 36367 36367
==========================================
- Hits 18302 18300 -2
- Misses 80974 81907 +933
- Partials 20479 20480 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
miursh
approved these changes
Dec 11, 2023
miursh
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 11, 2023
…oid exceeding max voxel size (autowarefoundation#5824)
7 tasks
tkimura4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 11, 2023
…oid exceeding max voxel size (#1065) fix(lidar_centerpoint,image_projection_based_fusion): add guard to avoid exceeding max voxel size (autowarefoundation#5824) Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
shmpwk
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 11, 2023
…oid exceeding max voxel size (autowarefoundation#5824)
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…oid exceeding max voxel size (autowarefoundation#5824)
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…oid exceeding max voxel size (autowarefoundation#5824) Signed-off-by: karishma <karishma@interpl.ai>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…oid exceeding max voxel size (autowarefoundation#5824) Signed-off-by: karishma <karishma@interpl.ai>
satoshi-ota
pushed a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
Jan 14, 2024
…oid exceeding max voxel size (autowarefoundation#5824)
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…oid exceeding max voxel size (autowarefoundation#5824)
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…oid exceeding max voxel size (autowarefoundation#5824)
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…oid exceeding max voxel size (autowarefoundation#5824)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When voxel size exceeds max voxel size, cuda illegal memory access occurs.
This PR adds guard to avoid exceeding max voxel size.
🤖[deprecated] Generated by Copilot at 38887d0
This pull request adds a new parameter
max_voxel_sizeto thegenerateBaseFeatures_kernelfunction and its related functions in theperception/image_projection_based_fusionandperception/lidar_centerpointmodules. The parameter is used to limit the number of points per voxel and filter out invalid voxels for the pointpainting fusion algorithm. The parameter value is configured in the launch files and passed to the function calls.Tests performed
checked in tier4 internal evaluation system.
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.