Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(localization_util): fixed rejection criteria of SmartPoseBuffer::interpolate #5818

Conversation

SakodaShintaro
Copy link
Contributor

@SakodaShintaro SakodaShintaro commented Dec 8, 2023

Description

Fixed rejection criteria of SmartPoseBuffer::interpolate.

See comments in changed code.

Tests performed

It has been confirmed that the logging_simulator runs with the same accuracy as before on AWSIM data with GT.

Effects on system behavior

There are no effects on system behavior for basic vehicles.

In environments where LiDAR is lightweight, such as AWSIM, SmartPoseBuffer::interpolate are less likely to fail.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Dec 8, 2023
@SakodaShintaro SakodaShintaro added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 264 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (7cce245) 12.88%.
Report is 180 commits behind head on main.

Files Patch % Lines
...tag_based_localizer/src/ar_tag_based_localizer.cpp 0.00% 79 Missing and 5 partials ⚠️
...ocalizer/landmark_manager/src/landmark_manager.cpp 0.00% 63 Missing ⚠️
...ion/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp 2.04% 35 Missing and 13 partials ⚠️
...zation/localization_util/src/smart_pose_buffer.cpp 47.61% 12 Missing and 21 partials ⚠️
.../localization_util/test/test_smart_pose_buffer.cpp 43.39% 0 Missing and 30 partials ⚠️
localization/ndt_scan_matcher/src/particle.cpp 0.00% 4 Missing ⚠️
...sed_localizer/ar_tag_based_localizer/test/test.cpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5818       +/-   ##
===========================================
- Coverage   15.32%   12.88%    -2.45%     
===========================================
  Files        1721       14     -1707     
  Lines      118559     1172   -117387     
  Branches    37995      663    -37332     
===========================================
- Hits        18169      151    -18018     
+ Misses      79657      799    -78858     
+ Partials    20733      222    -20511     
Flag Coverage Δ
differential 12.88% <20.24%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SakodaShintaro SakodaShintaro self-assigned this Dec 11, 2023
@SakodaShintaro SakodaShintaro marked this pull request as ready for review December 11, 2023 00:14
Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SakodaShintaro SakodaShintaro merged commit 89d4462 into autowarefoundation:main Dec 11, 2023
33 of 35 checks passed
@SakodaShintaro SakodaShintaro deleted the fix/smart_pose_buffer_rejection_criteria branch December 11, 2023 00:38
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
…interpolate (autowarefoundation#5818)

Fixed rejection criteria of SmartPoseBuffer::interpolate

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…interpolate (autowarefoundation#5818)

Fixed rejection criteria of SmartPoseBuffer::interpolate

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…interpolate (autowarefoundation#5818)

Fixed rejection criteria of SmartPoseBuffer::interpolate

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…interpolate (autowarefoundation#5818)

Fixed rejection criteria of SmartPoseBuffer::interpolate

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…interpolate (autowarefoundation#5818)

Fixed rejection criteria of SmartPoseBuffer::interpolate

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…interpolate (autowarefoundation#5818)

Fixed rejection criteria of SmartPoseBuffer::interpolate

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants