Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(system_diagnostic_graph): support config override and add tests #5816

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Dec 8, 2023

Description

  • Add config override feature: This allows you to create a configuration with some modifications to an existing configuration.
  • Add tests.
  • Add warn remap.
  • Add graph dump tool.

Related links

None

Tests performed

colcon test --packages-select system_diagnostic_graph --event-handlers=console_cohesion+

Notes for reviewers

You can see the structure of the graph with the following command.

ros2 run system_diagnostic_graph tool <graph_file_path>

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Dec 8, 2023
@isamu-takagi isamu-takagi self-assigned this Dec 8, 2023
@isamu-takagi isamu-takagi added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (765a596) 15.32% compared to head (ad5d648) 39.71%.
Report is 179 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5816       +/-   ##
===========================================
+ Coverage   15.32%   39.71%   +24.39%     
===========================================
  Files        1721       14     -1707     
  Lines      118559      637   -117922     
  Branches    37995      261    -37734     
===========================================
- Hits        18169      253    -17916     
+ Misses      79657      227    -79430     
+ Partials    20733      157    -20576     
Flag Coverage Δ
differential 39.71% <ø> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mkuri mkuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed to pass all tests.

@isamu-takagi isamu-takagi merged commit 9b4cd9c into autowarefoundation:main Dec 8, 2023
36 of 38 checks passed
@isamu-takagi isamu-takagi deleted the feat/system-diagnostic-graph-add-config-edit branch December 8, 2023 12:25
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…utowarefoundation#5816)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…utowarefoundation#5816)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
isamu-takagi added a commit to tier4/autoware.universe that referenced this pull request Dec 19, 2023
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants