Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(motion_utils): stop using CAPACITY from Trajectory message #5755

Conversation

maxime-clem
Copy link
Contributor

Description

After this PR the CAPACITY constant from the Trajectory message is no longer used in the universe code.
Required by autowarefoundation/autoware_msgs#76

Tests performed

Psim

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Dec 2, 2023
@maxime-clem maxime-clem added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:common Common packages from the autoware-common repository. (auto-assigned) labels Dec 2, 2023
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Attention: 1456 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (2edb215) 18.79%.
Report is 134 commits behind head on main.

Files Patch % Lines
...anner/src/utils/avoidance/shift_line_generator.cpp 13.19% 435 Missing and 65 partials ⚠️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 3.75% 195 Missing and 10 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.cpp 0.58% 168 Missing and 2 partials ⚠️
...er/src/scene_module/avoidance/avoidance_module.cpp 10.48% 111 Missing and 17 partials ⚠️
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 1.56% 63 Missing ⚠️
..._path_planner/src/marker_utils/avoidance/debug.cpp 0.00% 61 Missing ⚠️
...cene_module/start_planner/start_planner_module.cpp 8.47% 54 Missing ⚠️
..._departure_checker_node/lane_departure_checker.cpp 0.00% 28 Missing ⚠️
...th_planner/src/scene_module/lane_change/normal.cpp 0.00% 28 Missing ⚠️
...ath_planner/src/scene_module/avoidance/manager.cpp 24.24% 0 Missing and 25 partials ⚠️
... and 39 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5755      +/-   ##
==========================================
+ Coverage   15.32%   18.79%   +3.47%     
==========================================
  Files        1721      535    -1186     
  Lines      118559    55603   -62956     
  Branches    37995    28149    -9846     
==========================================
- Hits        18169    10451    -7718     
+ Misses      79657    31029   -48628     
+ Partials    20733    14123    -6610     
Flag Coverage Δ
differential 18.79% <12.44%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@shulanbushangshu shulanbushangshu merged commit f582b5a into autowarefoundation:main Dec 8, 2023
31 of 33 checks passed
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…utowarefoundation#5755)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…utowarefoundation#5755)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
yuki-takagi-66 added a commit to tier4/autoware.universe that referenced this pull request Dec 20, 2023
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
@maxime-clem maxime-clem deleted the refactor/motion_utils-rm-CAPACITY branch June 28, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants