Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): regulate at the traffic light #5457

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Nov 1, 2023

Description

Regulate lane change at the traffic light.
In this PR, by setting regulate_on_traffic_light to true, lane change module accepts path only when

  1. lane changing start pose is after traffic light's stop line.
  2. lane changing end pose is before traffic light's stop line.

Before PR

Screenshot from 2023-11-01 19-32-56

After PR

cap-.2023-11-01-18-38-36.mp4

Logic

Screenshot from 2023-11-01 19-33-21

Screenshot from 2023-11-01 19-33-31

Related links

Parameter is needed autowarefoundation/autoware_launch#673

Tests performed

Evaluator's result https://evaluation.tier4.jp/evaluation/reports/9838be5d-03a2-5bca-94f1-f2170b0ea15a?project_id=prd_jt

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 1, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (a29c7da) 14.79% compared to head (64a80d8) 14.79%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5457      +/-   ##
==========================================
- Coverage   14.79%   14.79%   -0.01%     
==========================================
  Files        1684     1684              
  Lines      116772   116785      +13     
  Branches    36271    36277       +6     
==========================================
  Hits        17277    17277              
- Misses      79989    80000      +11     
- Partials    19506    19508       +2     
Flag Coverage Δ *Carryforward flag
differential 12.13% <0.00%> (?)
total 14.79% <ø> (ø) Carriedforward from a29c7da

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...r_path_planner/scene_module/lane_change/normal.hpp 50.00% <ø> (ø)
...nner/utils/lane_change/lane_change_module_data.hpp 0.00% <ø> (ø)
...nner/include/behavior_path_planner/utils/utils.hpp 45.45% <ø> (ø)
...h_planner/src/scene_module/lane_change/manager.cpp 4.16% <0.00%> (-0.04%) ⬇️
...th_planner/src/scene_module/lane_change/normal.cpp 3.68% <0.00%> (-0.05%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 9071619 into autowarefoundation:main Nov 17, 2023
20 of 24 checks passed
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
)

* fix(lane_change): regulate at the traffic light

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix conflict

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the fix-lane-change-at-traffic-light branch December 4, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants