Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): regulate at the traffic light #673

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Nov 1, 2023

Description

autowarefoundation/autoware.universe#5457

Regulate lane change at the traffic light.
In this PR, by setting regulate_on_traffic_light to true, lane change module accepts path only when

  1. lane changing start pose is after traffic light's stop line.
  2. lane changing end pose is before traffic light's stop line.

Before PR

Screenshot from 2023-11-01 19-32-56

After PR

cap-.2023-11-01-18-38-36.mp4

Logic

Screenshot from 2023-11-01 19-33-21

Screenshot from 2023-11-01 19-33-31

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 1d365ed into main Nov 17, 2023
11 of 12 checks passed
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the fix-lane-change-at-traffic-light branch November 17, 2023 06:57
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
* Revert "feat: disable autonomous_emergency_braking (autowarefoundation#673)"

This reverts commit c0843ae.

* feat: use multithread for control_container

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Co-authored-by: tkimura4 <tkimura4@users.noreply.github.com>
yuki-takagi-66 pushed a commit to tier4/autoware_launch that referenced this pull request Jul 8, 2024
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants