Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(intersection): yield stuck stop #5403

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Oct 25, 2023

Description

No need to check if it's a private area or not for YieldStuckStop.

Tests performed

psim
scenario test:
https://evaluation.tier4.jp/evaluation/reports/b2f67d83-d5cd-51bf-88f9-4b14dcf4f900?project_id=prd_jt
https://evaluation.tier4.jp/evaluation/reports/41d24c0b-6ff6-5962-a723-a3f418ccaf1d?project_id=prd_jt

Effects on system behavior

nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 25, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review October 25, 2023 02:24
@takayuki5168 takayuki5168 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (f400b91) 14.78% compared to head (9882cc1) 14.77%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5403      +/-   ##
==========================================
- Coverage   14.78%   14.77%   -0.01%     
==========================================
  Files        1661     1661              
  Lines      115453   115489      +36     
  Branches    35644    35664      +20     
==========================================
  Hits        17068    17068              
- Misses      79153    79185      +32     
- Partials    19232    19236       +4     
Flag Coverage Δ *Carryforward flag
differential 5.63% <0.00%> (?)
total 14.78% <ø> (+<0.01%) ⬆️ Carriedforward from f400b91

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ity_intersection_module/src/scene_intersection.hpp 0.00% <ø> (ø)
...ior_velocity_intersection_module/src/util_type.hpp 0.00% <ø> (ø)
...ehavior_velocity_intersection_module/src/debug.cpp 0.00% <0.00%> (ø)
...avior_velocity_intersection_module/src/manager.cpp 14.18% <0.00%> (-0.16%) ⬇️
...behavior_velocity_intersection_module/src/util.cpp 0.00% <0.00%> (ø)
...ity_intersection_module/src/scene_intersection.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit 82a6c0c into autowarefoundation:main Oct 25, 2023
44 of 47 checks passed
@takayuki5168 takayuki5168 deleted the fix/yield-stuck-stop-main branch October 25, 2023 11:27
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Oct 25, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Oct 25, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
t4-x2 added a commit to tier4/autoware.universe that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants