Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(out_of_lane): more stable decisions #5197

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Oct 2, 2023

Description

Make the out_of_lanes decision more stable and add useful debug visualization markers.

Related links

Launch PR: autowarefoundation/autoware_launch#612

Tests performed

Psim
Evaluator (TIER IV INTERNAL LINK): https://evaluation.tier4.jp/evaluation/reports/cb6966cc-9b7e-56aa-9953-c82b9c1b30bf?project_id=prd_jt

Notes for reviewers

Interface changes

Effects on system behavior

More stable decisions from the out_of_lane module.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@maxime-clem maxime-clem added component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Oct 2, 2023
@maxime-clem maxime-clem force-pushed the feat/out_of_lane-more_stable-universe branch from c44cd02 to 1600573 Compare October 3, 2023 01:55
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Oct 3, 2023
@maxime-clem maxime-clem force-pushed the feat/out_of_lane-more_stable-universe branch from 1600573 to b54df47 Compare October 3, 2023 02:41
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 112 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (561bc6d) 14.78%.

❗ Current head 561bc6d differs from pull request most recent head 990b48f. Consider uploading reports for the commit 990b48f to get more accurate results

Files Patch % Lines
...behavior_velocity_out_of_lane_module/src/debug.cpp 11.66% 44 Missing and 9 partials ⚠️
...ocity_out_of_lane_module/src/scene_out_of_lane.cpp 13.88% 12 Missing and 19 partials ⚠️
...vior_velocity_out_of_lane_module/src/decisions.cpp 0.00% 9 Missing ⚠️
...t_of_lane_module/src/calculate_slowdown_points.hpp 0.00% 7 Missing ⚠️
...ocity_out_of_lane_module/src/overlapping_range.cpp 0.00% 5 Missing ⚠️
...behavior_velocity_out_of_lane_module/src/types.hpp 61.53% 3 Missing and 2 partials ⚠️
...havior_velocity_out_of_lane_module/src/manager.cpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5197      +/-   ##
==========================================
- Coverage   15.32%   14.78%   -0.55%     
==========================================
  Files        1721     1637      -84     
  Lines      118559   113681    -4878     
  Branches    37995    34954    -3041     
==========================================
- Hits        18168    16804    -1364     
+ Misses      79657    78021    -1636     
+ Partials    20734    18856    -1878     
Flag Coverage Δ *Carryforward flag
differential 22.29% <15.15%> (?)
total 14.78% <ø> (-0.55%) ⬇️ Carriedforward from 6e49e82

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem force-pushed the feat/out_of_lane-more_stable-universe branch from b54df47 to 561bc6d Compare October 3, 2023 05:33
@github-actions github-actions bot removed the type:documentation Creating or refining documentation. (auto-assigned) label Oct 3, 2023
@maxime-clem maxime-clem marked this pull request as ready for review October 3, 2023 05:34
@maxime-clem maxime-clem merged commit 6c84559 into autowarefoundation:main Nov 16, 2023
18 of 21 checks passed
@maxime-clem maxime-clem deleted the feat/out_of_lane-more_stable-universe branch November 16, 2023 09:06
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants