Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(out_of_lane): more stable decisions #612

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Oct 2, 2023

Description

Add two new parameters required by PR autowarefoundation/autoware.universe#5197
Also disable the skip_if_already_overlapping feature.

Tests performed

Psim
Evaluator (TIER IV INTERNAL LINK): https://evaluation.tier4.jp/evaluation/reports/cb6966cc-9b7e-56aa-9953-c82b9c1b30bf?project_id=prd_jt

Effects on system behavior

More stable decisions from the out_of_lane module.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@maxime-clem maxime-clem changed the title Feat/out of lane more stable universe feat(out_of_lane): more stable decisions Oct 2, 2023
@maxime-clem maxime-clem force-pushed the feat/out_of_lane-more_stable-universe branch from f9cfb8a to a095d15 Compare October 3, 2023 01:55
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem force-pushed the feat/out_of_lane-more_stable-universe branch from a095d15 to 6b237ef Compare October 3, 2023 05:33
TomohitoAndo pushed a commit to TomohitoAndo/autoware_launch.awf that referenced this pull request Oct 20, 2023
@maxime-clem maxime-clem merged commit 8f660e4 into autowarefoundation:main Nov 16, 2023
10 of 11 checks passed
@maxime-clem maxime-clem deleted the feat/out_of_lane-more_stable-universe branch November 16, 2023 09:06
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
* feat: apply acceleration for emergency deceleration (-0.6G)

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

* feat: apply behavior deceleration (-0.4G)

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

* feat: apply comfortable stop/launch acceleration settings

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

---------

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
yuki-takagi-66 referenced this pull request in tier4/autoware_launch Jul 8, 2024
* feat: apply acceleration for emergency deceleration (-0.6G)

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

* feat: apply behavior deceleration (-0.4G)

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

* feat: apply comfortable stop/launch acceleration settings

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

---------

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants