Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(map_loader): display curbstone as marker array #4958

Merged
merged 4 commits into from
Oct 25, 2023

Merge branch 'main' into feat/curbstone-markerarray

4327ea9
Select commit
Loading
Failed to load commit list.
Merged

feat(map_loader): display curbstone as marker array #4958

Merge branch 'main' into feat/curbstone-markerarray
4327ea9
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Sep 25, 2023 in 34s

CodeScene PR Check

❌ Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Negative Code Health Impact (highest to lowest):

  • Large Method lanelet2_map_visualization_node.cpp: Lanelet2MapVisualizationNode::onMapBin

Annotations

Check warning on line 250 in map/map_loader/src/lanelet2_map_loader/lanelet2_map_visualization_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method 

Lanelet2MapVisualizationNode::onMapBin increases from 154 to 159 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis