-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(freespace_planning_algorithms): fix declare_parameter function's declaration #4645
refactor(freespace_planning_algorithms): fix declare_parameter function's declaration #4645
Conversation
…ction declare_parameter
…ce_planning_algorithms
…meter function and add config repository.
…ce_planning_algorithms
…ce_planning_algorithms
…e_planning_algorithms Signed-off-by: keiota <k3robot@gmail.com>
…hub.com:keiota/autoware.universe into refactor/planning/freespace_planning_algorithms
…e_planning_algorithms
…arameter function
…e_planning_algorithms Signed-off-by: keiota <k3robot@gmail.com>
…hub.com:keiota/autoware.universe into refactor/planning/freespace_planning_algorithms
…e_planning_algorithms Signed-off-by: keiota <k3robot@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4645 +/- ##
==========================================
- Coverage 14.88% 14.88% -0.01%
==========================================
Files 1549 1549
Lines 106993 106997 +4
Branches 32805 32807 +2
==========================================
Hits 15925 15925
- Misses 73671 73675 +4
Partials 17397 17397
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
631f44a
into
autowarefoundation:main
…on's declaration (autowarefoundation#4645) * refactor(freespace_planning_algorithms): delete default values of function declare_parameter * refactor(freespace_planning_algorithms): fix way to call declare_parameter function and add config repository. * refactor(freespace_planning_algorithms): fix way to declare declare_parameter function * fix(freespace_planner): add parameters for RRTStar search algorithm * style(pre-commit): autofix * refactor(freespace_planner): undo the change of planning algorithm --------- Signed-off-by: keiota <k3robot@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
Description
In this PR,
Purpose of this change is to prevent incorrectly starting nodes up without parameter's definition on config files.
Parameters are also defined on another PR so we can remove declaration of default value from declare_parameter function.
Before this PR
When removing parameters that are written directly in the source, the node does not start properly and the ego stops after transitioning to the parking scenario.
Showing an error
Component constructor threw an exception: Statically typed parameter 'rrtstar.enable_update' must be initialized.
in next log line 509.Next video is the scene failing to transit to parking scenario.
After this PR
The parking scenario is performed successfully because parameters were added to the parameter file.
Comparing to previous log, in the next log line 512 shows success to intilize parameter.
Next video is the scene successing to transit to parking scenario.
Tests performed
change an algorithm from Astar to RRTstar by changing launch file
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.