Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crosswalk): add option to disable yield for new stopped object #4465

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jul 31, 2023

Description

Depends on #4463

Add an option to disable yield for new stopped object.

This option is to achieve aggressive behavior for complex scenes as follows.
In this situation, the pedestrians often appear or disappear due to occlusion and perception's performance limitation.
In order not to yield for 3 seconds for new appeared pedestrians, this option will be useful.
image

Tests performed

Effects on system behavior

Nothing by default

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 31, 2023
@takayuki5168 takayuki5168 changed the title Feat/disable yield for stopped object feat(crosswalk): add option to disable yield for new stopped object Jul 31, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review July 31, 2023 06:45
@takayuki5168 takayuki5168 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (8a82fa9) 14.91% compared to head (974afc0) 14.91%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4465      +/-   ##
==========================================
- Coverage   14.91%   14.91%   -0.01%     
==========================================
  Files        1517     1517              
  Lines      104695   104707      +12     
  Branches    31880    31893      +13     
==========================================
  Hits        15619    15619              
- Misses      72024    72034      +10     
- Partials    17052    17054       +2     
Flag Coverage Δ *Carryforward flag
differential 11.19% <0.00%> (?)
total 14.91% <0.00%> (+<0.01%) ⬆️ Carriedforward from 97d5dd1

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ule/dynamic_avoidance/dynamic_avoidance_module.hpp 0.00% <0.00%> (ø)
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% <0.00%> (ø)
...behavior_velocity_crosswalk_module/src/manager.cpp 13.33% <0.00%> (-0.31%) ⬇️
..._velocity_crosswalk_module/src/scene_crosswalk.cpp 0.00% <0.00%> (ø)
..._velocity_crosswalk_module/src/scene_crosswalk.hpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit cd9f5ce into autowarefoundation:main Aug 1, 2023
42 of 47 checks passed
@takayuki5168 takayuki5168 deleted the feat/disable-yield-for-stopped-object branch August 1, 2023 09:43
felixf4xu pushed a commit to felixf4xu/autoware.universe that referenced this pull request Aug 2, 2023
…utowarefoundation#4465)

* feat(crosswalk): disable cancel yield at no traffic signals intersection

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(crosswalk): add option to disable yield for new stopped object

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Felix F Xu <felixfxu@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Aug 9, 2023
…utowarefoundation#4465)

* feat(crosswalk): disable cancel yield at no traffic signals intersection

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(crosswalk): add option to disable yield for new stopped object

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Sep 15, 2023
…utowarefoundation#4465)

* feat(crosswalk): disable cancel yield at no traffic signals intersection

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(crosswalk): add option to disable yield for new stopped object

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants