Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(planning): fix -Werror=deprecated-declaration #4414

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jul 26, 2023

Description

🤖 Generated by Copilot at 9723b4b

Use ConstSharedPtr for message pointers in several planning nodes. This improves performance, memory efficiency, and const-correctness by avoiding unnecessary copies of odometry and path messages.

/home/satoshi/pilot-auto/src/autoware/universe/planning/path_smoother/src/elastic_band_smoother.cpp:71:40:   required from here
/opt/ros/humble/include/rclcpp/rclcpp/any_subscription_callback.hpp:391:21: error: ‘void rclcpp::AnySubscriptionCallback<MessageT, AllocatorT>::set_deprecated(std::function<void(std::shared_ptr<_Yp>)>) [with SetT = autoware_auto_planning_msgs::msg::Path_<std::allocator<void> >; MessageT = autoware_auto_planning_msgs::msg::Path_<std::allocator<void> >; AllocatorT = std::allocator<void>]’ is deprecated: use 'void(std::shared_ptr<const MessageT>)' instead [-Werror=deprecated-declarations]
  391 |       set_deprecated(static_cast<typename scbth::callback_type>(callback));
      |       ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Tests performed

Nothing.

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 26, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review July 26, 2023 22:44
@satoshi-ota satoshi-ota added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 26, 2023
@satoshi-ota satoshi-ota enabled auto-merge (squash) July 26, 2023 23:53
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 83.33% and no project coverage change.

Comparison is base (13b96ad) 14.93% compared to head (9723b4b) 14.93%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4414   +/-   ##
=======================================
  Coverage   14.93%   14.93%           
=======================================
  Files        1515     1515           
  Lines      104545   104545           
  Branches    31777    31777           
=======================================
  Hits        15613    15613           
  Misses      71895    71895           
  Partials    17037    17037           
Flag Coverage Δ *Carryforward flag
differential 17.11% <83.33%> (?)
total 14.93% <ø> (-0.01%) ⬇️ Carriedforward from 13b96ad

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...lanner/include/obstacle_avoidance_planner/node.hpp 40.00% <ø> (ø)
...er/include/path_smoother/elastic_band_smoother.hpp 40.00% <ø> (ø)
...ity_smoother/src/motion_velocity_smoother_node.cpp 28.25% <50.00%> (ø)
planning/obstacle_avoidance_planner/src/node.cpp 38.58% <100.00%> (ø)
...anning/path_smoother/src/elastic_band_smoother.cpp 36.43% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit f72b71b into autowarefoundation:main Jul 27, 2023
45 of 47 checks passed
@satoshi-ota satoshi-ota deleted the fix/build-error branch July 27, 2023 03:42
PhoebeWu21 pushed a commit to PhoebeWu21/autoware.universe that referenced this pull request Aug 18, 2023
…on#4414)

fix(planning): fix build error

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Oct 4, 2023
…on#4414)

fix(planning): fix build error

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Jan 14, 2024
…on#4414)

fix(planning): fix build error

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants