Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bpp-goal_planner): fix turn signal info for the right side pulling over #4410

Conversation

mehmetdogru
Copy link
Contributor

Description

closes #4409

Tests performed

Confirmed via created scenario. Please follow issue description -> Steps to reproduce

universe_4409_solved.mp4

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…g over

Signed-off-by: Mehmet Dogru <mdogru@leodrive.ai>
@mehmetdogru mehmetdogru added type:bug Software flaws or errors. component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jul 26, 2023
@mehmetdogru mehmetdogru self-assigned this Jul 26, 2023
@takayuki5168 takayuki5168 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 26, 2023
@mehmetdogru
Copy link
Contributor Author

@kosuke55 -san Could you take a look at this small PR?

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!! LGTM!

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (13b96ad) 14.93% compared to head (b340fef) 14.93%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4410      +/-   ##
==========================================
- Coverage   14.93%   14.93%   -0.01%     
==========================================
  Files        1515     1515              
  Lines      104545   104548       +3     
  Branches    31777    31777              
==========================================
  Hits        15613    15613              
- Misses      71895    71898       +3     
  Partials    17037    17037              
Flag Coverage Δ *Carryforward flag
differential 13.42% <0.00%> (?)
total 14.93% <ø> (+<0.01%) ⬆️ Carriedforward from 13b96ad

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
.../scene_module/goal_planner/goal_planner_module.cpp 6.06% <0.00%> (-0.03%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mehmetdogru mehmetdogru merged commit 9f6fdce into autowarefoundation:main Jul 27, 2023
41 of 44 checks passed
@mehmetdogru mehmetdogru deleted the 4409-fix-turn-signal-info-for-right-side-pulling-over branch July 27, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:bug Software flaws or errors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Right turn signal is not turned on while pulling over for the right side shoulder
3 participants