Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mpc_lateral_controller): fix typo #4404

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jul 26, 2023

Description

fix typo of mpc_lateral_controller

Tests performed

spell check

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Jul 26, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review July 26, 2023 12:55
@takayuki5168
Copy link
Contributor Author

@TakaHoribe Could you approve the PR

@takayuki5168 takayuki5168 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (13b96ad) 14.93% compared to head (483cdb0) 14.93%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4404   +/-   ##
=======================================
  Coverage   14.93%   14.93%           
=======================================
  Files        1515     1517    +2     
  Lines      104545   104552    +7     
  Branches    31777    31778    +1     
=======================================
+ Hits        15613    15619    +6     
  Misses      71895    71895           
- Partials    17037    17038    +1     
Flag Coverage Δ *Carryforward flag
differential 46.95% <ø> (?)
total 14.93% <ø> (ø) Carriedforward from 13b96ad

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ntroller/qp_solver/qp_solver_unconstraint_fast.hpp 100.00% <ø> (ø)
..._lateral_controller/src/mpc_lateral_controller.cpp 44.06% <ø> (ø)
...ller/src/qp_solver/qp_solver_unconstraint_fast.cpp 83.33% <ø> (ø)
control/mpc_lateral_controller/test/test_mpc.cpp 51.31% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HansRobo HansRobo changed the title fix(mpc_lateral_controller): fix typo chore(mpc_lateral_controller): fix typo Jul 27, 2023
@takayuki5168 takayuki5168 merged commit 9311b89 into autowarefoundation:main Jul 27, 2023
36 of 38 checks passed
@takayuki5168 takayuki5168 deleted the fix/mpc-typo branch July 27, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants