Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_cruise_planner): suppress flickering to entry slow down #3904

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jun 5, 2023

Description

suppress flickering of slow down entry/exit

Tests performed

planning simulator & real vehicle

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 takayuki5168 changed the title Feat/entry slow down suppress flickering feat(obstacle_cruise_planner): suppress flickering to entry slow down Jun 5, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review June 5, 2023 09:01
@takayuki5168 takayuki5168 requested review from purewater0901 and a team as code owners June 5, 2023 09:01
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 5, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/entry-slow-down-suppress-flickering branch from f3ab310 to a8a5061 Compare June 5, 2023 15:28
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 2.15% and project coverage change: -0.01 ⚠️

Comparison is base (66918d8) 15.06% compared to head (200cc50) 15.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3904      +/-   ##
==========================================
- Coverage   15.06%   15.05%   -0.01%     
==========================================
  Files        1340     1341       +1     
  Lines       95628    95698      +70     
  Branches    27311    27342      +31     
==========================================
+ Hits        14404    14406       +2     
- Misses      65416    65478      +62     
- Partials    15808    15814       +6     
Flag Coverage Δ *Carryforward flag
differential 8.57% <2.15%> (?)
total 15.06% <ø> (+<0.01%) ⬆️ Carriedforward from 66918d8

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...include/obstacle_cruise_planner/common_structs.hpp 9.52% <0.00%> (-0.48%) ⬇️
...lude/obstacle_cruise_planner/planner_interface.hpp 13.51% <ø> (ø)
planning/obstacle_cruise_planner/src/node.cpp 12.51% <0.00%> (-0.54%) ⬇️
.../obstacle_cruise_planner/src/planner_interface.cpp 8.16% <0.00%> (-0.67%) ⬇️
...e_planner/include/obstacle_cruise_planner/node.hpp 11.11% <11.11%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit 30253b1 into autowarefoundation:main Jun 5, 2023
@takayuki5168 takayuki5168 deleted the feat/entry-slow-down-suppress-flickering branch June 5, 2023 16:53
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Jun 20, 2023
…autowarefoundation#3904)

* feat(obstacle_cruise_planner): suppress flickering to entry slow down

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants