Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avoidance): additional buffer for perception noise #3855

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented May 29, 2023

Description

Assumption: Perception results for far objects have larger detection error than the result for near one.

Sometimes, the avoidance module changes the judgement whether the ego should avoid or not after the ego gets quite a bit closer to the object because of the detection error. The judgement chattering causes unexpected sudden deceleration so that the module keeps avoidable distance to object.

In this PR, it is able to set max_expand_ratio > 0, and the avoidance module expands objects envelope_polygon_buffer and safety_buffer_lateral based on the distance between the ego and object so that far objects are judged to be avoided more frequently than nearby objects. As a result, it prevents a sudden change from "not need to avoid" to "should avoid" after approaching it.

image

image

⬇️ This must be merged before this PR.
autowarefoundation/autoware_launch#373

Tests performed

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 29, 2023
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (959f3e4) 15.43% compared to head (1f0fcc9) 15.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3855   +/-   ##
=======================================
  Coverage   15.43%   15.44%           
=======================================
  Files        1350     1350           
  Lines       96002    95951   -51     
  Branches    29700    29658   -42     
=======================================
  Hits        14817    14817           
+ Misses      65033    64975   -58     
- Partials    16152    16159    +7     
Flag Coverage Δ *Carryforward flag
differential 13.12% <0.00%> (?)
total 15.45% <ø> (+0.02%) ⬆️ Carriedforward from 959f3e4

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <ø> (ø)
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 18.53% <0.00%> (-0.12%) ⬇️
...er/src/scene_module/avoidance/avoidance_module.cpp 4.05% <0.00%> (+0.17%) ⬆️
...ne_module/lane_change/avoidance_by_lane_change.cpp 0.00% <0.00%> (ø)
...cene_module/start_planner/start_planner_module.cpp 5.69% <0.00%> (-0.11%) ⬇️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 2.93% <0.00%> (-0.01%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota force-pushed the feat/additional-buffer-for-perception-noise branch from 11e4d42 to 36e7503 Compare June 1, 2023 08:08
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 01000fc into autowarefoundation:main Jun 15, 2023
@satoshi-ota satoshi-ota deleted the feat/additional-buffer-for-perception-noise branch June 15, 2023 01:21
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Jun 20, 2023
…dation#3855)

* feat(avoidance): additional buffer for perception noise

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): expand safety buffer by distance

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Jun 20, 2023
…dation#3855)

* feat(avoidance): additional buffer for perception noise

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): expand safety buffer by distance

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants