-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(avoidance): additional buffer for perception noise #3855
feat(avoidance): additional buffer for perception noise #3855
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3855 +/- ##
=======================================
Coverage 15.43% 15.44%
=======================================
Files 1350 1350
Lines 96002 95951 -51
Branches 29700 29658 -42
=======================================
Hits 14817 14817
+ Misses 65033 64975 -58
- Partials 16152 16159 +7
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
11e4d42
to
36e7503
Compare
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
36e7503
to
1f0fcc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…dation#3855) * feat(avoidance): additional buffer for perception noise Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): expand safety buffer by distance Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…dation#3855) * feat(avoidance): additional buffer for perception noise Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): expand safety buffer by distance Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Description
Assumption: Perception results for far objects have larger detection error than the result for near one.
Sometimes, the avoidance module changes the judgement whether the ego should avoid or not after the ego gets quite a bit closer to the object because of the detection error. The judgement chattering causes unexpected sudden deceleration so that the module keeps avoidable distance to object.
In this PR, it is able to set
max_expand_ratio > 0
, and the avoidance module expands objectsenvelope_polygon_buffer
andsafety_buffer_lateral
based on the distance between the ego and object so that far objects are judged to be avoided more frequently than nearby objects. As a result, it prevents a sudden change from "not need to avoid" to "should avoid" after approaching it.⬇️ This must be merged before this PR.
autowarefoundation/autoware_launch#373
Tests performed
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.