refactor(behavior_path_planeer): use common.params for lane change #3520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yutaka <purewater0901@gmail.com>
purewater0901
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
zulfaqar-azmi-t4,
a team,
mkuri,
soblin and
TomohitoAndo
as code owners
github-actions
bot
added
component:launch
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3520 +/- ##
==========================================
+ Coverage 13.72% 14.06% +0.34%
==========================================
Files 1395 1397 +2
Lines 97999 98404 +405
Branches 29097 29383 +286
==========================================
+ Hits 13452 13843 +391
+ Misses 70101 69847 -254
- Partials 14446 14714 +268
*This pull request uses carry forward flags. Click here to find out more.
... and 21 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
rej55
approved these changes
Apr 25, 2023
github-actions
bot
added
the
type:documentation
Mingyu1991
pushed a commit
to Mingyu1991/autoware.universe
that referenced
this pull request
Jun 26, 2023
…utowarefoundation#3520) * refactor(behavior_path_planeer): use common.params for lane change Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> --------- Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use minimum acceleration from common params for the lane change module.
Related PR
Tests performed
PSim
Effects on system behavior
No effects on system behavior. Just remove the redundant parameters.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.