refactor(behavior_path_planner): remove toPolygon functions #3283
Conversation
Signed-off-by: yutaka <purewater0901@gmail.com>
purewater0901
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
zulfaqar-azmi-t4 and
a team
as code owners
github-actions
bot
added
the
component:planning
| const double & length_m = object_shape.dimensions.x / 2; | ||
| const double & width_m = object_shape.dimensions.y / 2; | ||
| *object_polygon = | ||
| convertBoundingBoxObjectToGeometryPolygon(object_pose, length_m, length_m, width_m); |
There was a problem hiding this comment.
Did you already remove this kind of detailed polygon functions?
There was a problem hiding this comment.
@takayuki5168 Thank you! I forgot to remove them.
There was a problem hiding this comment.
@takayuki5168
I removed most of them with this commit.
However, one function is still used in other place, so I'll leave it to the code and let me add it to the tier4_autoware_utils in another PR.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3283 +/- ##
=======================================
Coverage 12.42% 12.42%
=======================================
Files 1365 1365
Lines 95296 95275 -21
Branches 27190 27185 -5
=======================================
Hits 11837 11837
+ Misses 70943 70921 -22
- Partials 12516 12517 +1
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…foundation#3283) * refactor(behavior_path_planner): remove toPolygon functions Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> --------- Signed-off-by: yutaka <purewater0901@gmail.com>
Description
Remove
toPolygonfunctions from utils and avoidance module in the behavior path planner.Tests performed
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.