Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(map_loader): fix a bug that occurs when loading multiple pcds #3274

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Apr 5, 2023

🤖 Generated by Copilot at d882d09

Fix a typo and remove an unused variable in pointcloud_map_loader_node. This improves the code quality and functionality of the node that loads point cloud map metadata.

Description

Fix a bug

Tests performed

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda requested review from mitsudome-r, RyuYamamoto and a team as code owners April 5, 2023 07:02
@github-actions github-actions bot added the component:map Map creation, storage, and loading. (auto-assigned) label Apr 5, 2023
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e8887cc) 12.41% compared to head (d882d09) 12.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3274   +/-   ##
=======================================
  Coverage   12.41%   12.41%           
=======================================
  Files        1364     1364           
  Lines       95155    95155           
  Branches    27074    27074           
=======================================
  Hits        11811    11811           
  Misses      70921    70921           
  Partials    12423    12423           
Flag Coverage Δ *Carryforward flag
differential 34.15% <0.00%> (?)
total 12.41% <ø> (+<0.01%) ⬆️ Carriedforward from e8887cc

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...intcloud_map_loader/pointcloud_map_loader_node.cpp 1.78% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@RyuYamamoto RyuYamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda merged commit 0e1c63e into autowarefoundation:main Apr 6, 2023
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Apr 7, 2023
…towarefoundation#3274)

* fix(map_loader): fix a bug that occurs when loading multiple pcds

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* fix

Signed-off-by: kminoda <koji.minoda@tier4.jp>

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Apr 7, 2023
…towarefoundation#3274)

* fix(map_loader): fix a bug that occurs when loading multiple pcds

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* fix

Signed-off-by: kminoda <koji.minoda@tier4.jp>

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda deleted the fix/debug_when_using_multiple_pcd_maps branch August 10, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:map Map creation, storage, and loading. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants