Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_velocity_planner): remove unused "findEgoIndex" #3256

Conversation

maxime-clem
Copy link
Contributor

Description

Remove 2 unused functions.

Tests performed

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 4, 2023
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (37f67f5) 13.21% compared to head (ca89a2e) 13.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3256   +/-   ##
=======================================
  Coverage   13.21%   13.22%           
=======================================
  Files        1263     1263           
  Lines       89337    89316   -21     
  Branches    27079    27074    -5     
=======================================
  Hits        11809    11809           
+ Misses      65104    65083   -21     
  Partials    12424    12424           
Flag Coverage Δ *Carryforward flag
differential 3.92% <ø> (?)
total 13.22% <ø> (+<0.01%) ⬆️ Carriedforward from 37f67f5

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/include/behavior_path_planner/utilities.hpp 83.33% <ø> (+59.52%) ⬆️
...nning/behavior_path_planner/src/path_utilities.cpp 0.00% <ø> (ø)
planning/behavior_path_planner/src/utilities.cpp 7.60% <ø> (+0.03%) ⬆️
...er/include/scene_module/scene_module_interface.hpp 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxime-clem maxime-clem merged commit 25c154d into autowarefoundation:main Apr 4, 2023
@maxime-clem maxime-clem deleted the cleanup/behavior_velocity_planner-rm_unused_fn branch April 4, 2023 02:11
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants