Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): use util funcitons for interpolation #3254

Merged
merged 5 commits into from
Apr 4, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Apr 3, 2023

Description

Use interpolation functions from tier4_autoware_utils and motion_utils in the behavior path planner

Tests performed

Scenario Test 1198/1199
Internal Link

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Apr 3, 2023
@github-actions github-actions bot removed the component:common Common packages from the autoware-common repository. (auto-assigned) label Apr 3, 2023
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (442f9ac) 12.38% compared to head (5f68f0d) 12.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3254   +/-   ##
=======================================
  Coverage   12.38%   12.39%           
=======================================
  Files        1363     1363           
  Lines       95194    95181   -13     
  Branches    27007    27006    -1     
=======================================
  Hits        11793    11793           
+ Misses      71044    71031   -13     
  Partials    12357    12357           
Flag Coverage Δ *Carryforward flag
differential 5.52% <0.00%> (?)
total 12.39% <ø> (+<0.01%) ⬆️ Carriedforward from cfc4a2e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...n_utils/test/src/trajectory/test_interpolation.cpp 18.15% <ø> (ø)
...lanner/include/behavior_path_planner/utilities.hpp 83.33% <ø> (+59.52%) ⬆️
...nning/behavior_path_planner/src/path_utilities.cpp 0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utilities.cpp 7.56% <0.00%> (-0.01%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901 purewater0901 merged commit 90ed30d into main Apr 4, 2023
@purewater0901 purewater0901 deleted the feat/use-util-interpolation branch April 4, 2023 01:07
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Apr 7, 2023
…towarefoundation#3254)

* feat(motion_utils): add new interpolation function with length

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(behavior_path_planner): use util funcitons for interpolation

Signed-off-by: yutaka <purewater0901@gmail.com>

---------

Signed-off-by: yutaka <purewater0901@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants