Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_perception_launch): add missing parameter for voxel based compare map filter #3251

Merged

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Apr 3, 2023

Description

Fix pointcloud_map_filter.launch.py.
(Currently, pointcloud_map_filter does not launch when use_down_sample_filter is true. )

Related links

#3087

Tests performed

I comfirmed that the VoxelBasedCompareMapFilterComponent did not cause error when use_down_sample_filter is true.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ompare map filter

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 requested review from miursh, yukkysaito and a team as code owners April 3, 2023 10:51
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Apr 3, 2023
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
cc @Mingyu1991

@tkimura4 tkimura4 merged commit 442f9ac into autowarefoundation:main Apr 3, 2023
@tkimura4 tkimura4 deleted the fix/perception_launch_missing_param branch April 3, 2023 11:16
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Apr 7, 2023
…ompare map filter (autowarefoundation#3251)

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants