Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_path_planner): delete default values #3236

Conversation

yamazakiTasuku
Copy link
Contributor

@yamazakiTasuku yamazakiTasuku commented Mar 31, 2023

Description

Removed default values defined in declare_parameter function.
Also, some additional parameters are needed.

⬇️ This PR must be merged before this PR.
autowarefoundation/autoware_launch#272

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 31, 2023
@satoshi-ota satoshi-ota changed the title Behavior path planner delete param refactor(behavior_path_planner): delete default values Apr 2, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the behavior_path_planner_delete_param branch from d382c2a to fe8d0b6 Compare April 6, 2023 03:44
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.10 ⚠️

Comparison is base (afb55c3) 13.25% compared to head (fe8d0b6) 13.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3236      +/-   ##
==========================================
- Coverage   13.25%   13.16%   -0.10%     
==========================================
  Files        1264     1267       +3     
  Lines       89359    90009     +650     
  Branches    27199    27529     +330     
==========================================
  Hits        11846    11846              
- Misses      64985    65634     +649     
- Partials    12528    12529       +1     
Flag Coverage Δ *Carryforward flag
differential 5.24% <0.00%> (?)
total 13.27% <ø> (+0.01%) ⬆️ Carriedforward from afb55c3

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ils/include/motion_utils/trajectory/trajectory.hpp 73.99% <ø> (ø)
...tion_utils/test/src/trajectory/test_trajectory.cpp 25.16% <ø> (ø)
...havior_path_planner/behavior_path_planner_node.hpp 0.00% <ø> (ø)
...th_planner/scene_module/avoidance_by_lc/module.hpp 0.00% <0.00%> (ø)
..._path_planner/util/avoidance_by_lc/module_data.hpp 0.00% <0.00%> (ø)
...lanner/include/behavior_path_planner/utilities.hpp 83.33% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.12% <0.00%> (-0.01%) ⬇️
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
...lanner/src/scene_module/avoidance_by_lc/module.cpp 0.00% <0.00%> (ø)
...ath_planner/src/util/path_shifter/path_shifter.cpp 0.00% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota self-assigned this Apr 6, 2023
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that this module works well in Psim. LGTM.

@satoshi-ota satoshi-ota merged commit d7daa4c into autowarefoundation:main Apr 6, 2023
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Apr 7, 2023
…ation#3236)

fix(behavior_path_planner): remove default values

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants