-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(behavior_path_planner): delete default values #3236
refactor(behavior_path_planner): delete default values #3236
Conversation
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
d382c2a
to
fe8d0b6
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3236 +/- ##
==========================================
- Coverage 13.25% 13.16% -0.10%
==========================================
Files 1264 1267 +3
Lines 89359 90009 +650
Branches 27199 27529 +330
==========================================
Hits 11846 11846
- Misses 64985 65634 +649
- Partials 12528 12529 +1
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that this module works well in Psim. LGTM.
…ation#3236) fix(behavior_path_planner): remove default values Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Co-authored-by: satoshi-ota <satoshi.ota928@gmail.com>
Description
Removed default values defined in declare_parameter function.
Also, some additional parameters are needed.
⬇️ This PR must be merged before this PR.
autowarefoundation/autoware_launch#272
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.