-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(avoidance): support new framework #2987
feat(avoidance): support new framework #2987
Conversation
24d5fc9
to
9751ace
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2987 +/- ##
==========================================
+ Coverage 11.93% 12.74% +0.80%
==========================================
Files 1321 1219 -102
Lines 91937 86093 -5844
Branches 24522 24543 +21
==========================================
- Hits 10976 10974 -2
+ Misses 69603 63758 -5845
- Partials 11358 11361 +3
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
9751ace
to
ad55953
Compare
92d2138
to
5258013
Compare
Both old and new frameworks works well. Old frameworkcap-.2023-03-09-11-40-00.mp4.mp4New frameworkcap-.2023-03-09-11-35-21.mp4.mp4 |
planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp
Show resolved
Hide resolved
planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
e184677
to
a8610fc
Compare
Description
⬇️ This must be merged before this PR.
autowarefoundation/autoware_launch#233
It is able to build avoidance module on new framework (added in #2919).
Related links
Tests performed
Checkout your branch of autoware_launch to
feat/support-new-framework-avoidance
.https://github.com/autowarefoundation/autoware_launch/tree/feat/support-new-framework-avoidance
In addtion, we may have to comment out module names which haven't supported new framework yet in rtc_auto_mode_manager.param.yaml.
Please set following flag to
FALSE
, and confirm to pass all build.autoware.universe/planning/behavior_path_planner/CMakeLists.txt
Line 10 in ad55953
Launch Psim and check the avoidance module working correctly.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.