Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avoidance): support new framework #2987

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Mar 2, 2023

Description

⬇️ This must be merged before this PR.
autowarefoundation/autoware_launch#233

It is able to build avoidance module on new framework (added in #2919).

Related links

Tests performed

Checkout your branch of autoware_launch to feat/support-new-framework-avoidance.
https://github.com/autowarefoundation/autoware_launch/tree/feat/support-new-framework-avoidance

In addtion, we may have to comment out module names which haven't supported new framework yet in rtc_auto_mode_manager.param.yaml.

/**:
  ros__parameters:
    module_list:
      - "blind_spot"
      - "crosswalk"
      - "detection_area"
      - "intersection"
      - "no_stopping_area"
      - "traffic_light"
      # - "ext_request_lane_change_left"
      # - "ext_request_lane_change_right"
      # - "lane_change_left"
      # - "lane_change_right"
      - "avoidance_left"
      - "avoidance_right"
      # - "pull_over"
      # - "pull_out"

Please set following flag to FALSE, and confirm to pass all build.

set(COMPILE_WITH_OLD_ARCHITECTURE TRUE)

Launch Psim and check the avoidance module working correctly.

rviz_screenshot_2023_03_03-08_18_17

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 2, 2023
@satoshi-ota satoshi-ota force-pushed the feat/support-new-framework-avoidance branch 3 times, most recently from 24d5fc9 to 9751ace Compare March 2, 2023 09:55
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.80 🎉

Comparison is base (7f064da) 11.93% compared to head (e184677) 12.74%.

❗ Current head e184677 differs from pull request most recent head a8610fc. Consider uploading reports for the commit a8610fc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2987      +/-   ##
==========================================
+ Coverage   11.93%   12.74%   +0.80%     
==========================================
  Files        1321     1219     -102     
  Lines       91937    86093    -5844     
  Branches    24522    24543      +21     
==========================================
- Hits        10976    10974       -2     
+ Misses      69603    63758    -5845     
- Partials    11358    11361       +3     
Flag Coverage Δ *Carryforward flag
differential 5.58% <0.00%> (?)
total 12.75% <ø> (+0.81%) ⬆️ Carriedforward from 5258013

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...havior_path_planner/behavior_path_planner_node.hpp 0.00% <ø> (ø)
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <0.00%> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.14% <0.00%> (-0.01%) ⬇️
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 80.95% <0.00%> (-4.77%) ⬇️
planning/behavior_path_planner/src/utilities.cpp 7.69% <0.00%> (-0.02%) ⬇️
planning/rtc_interface/src/rtc_interface.cpp 0.00% <0.00%> (ø)
...erception/traffic_light_classifier/src/nodelet.cpp 0.00% <0.00%> (ø)
... and 103 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zulfaqar-azmi-t4
Copy link
Contributor

Both old and new frameworks works well.

Old framework

cap-.2023-03-09-11-40-00.mp4.mp4

New framework

cap-.2023-03-09-11-35-21.mp4.mp4

Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the feat/support-new-framework-avoidance branch from e184677 to a8610fc Compare March 9, 2023 06:42
@satoshi-ota satoshi-ota enabled auto-merge (squash) March 9, 2023 06:52
@satoshi-ota satoshi-ota merged commit 4c518fb into autowarefoundation:main Mar 9, 2023
@satoshi-ota satoshi-ota deleted the feat/support-new-framework-avoidance branch March 9, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants