Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Check tutor type on page revisit before displaying inline feedback (fixes #91) #92

Merged
merged 3 commits into from
Apr 21, 2023
Merged

Fix: Check tutor type on page revisit before displaying inline feedback (fixes #91) #92

merged 3 commits into from
Apr 21, 2023

Conversation

joe-allen-89
Copy link
Contributor

Fixes (#91)

Fix

@joe-allen-89 joe-allen-89 self-assigned this Apr 20, 2023
@joe-allen-89 joe-allen-89 linked an issue Apr 20, 2023 that may be closed by this pull request
Completed question component feedback popups opening up on page load #91
Closed
kirsty-hames
kirsty-hames approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm fix testing on Mac safari/FF/Chrome and iPhone.

guywillis
guywillis approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Chrome, working as expected

eleanor-heath
eleanor-heath approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@eleanor-heath eleanor-heath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved - left a couple of minor comments

joe-allen-89 and others added 2 commits April 20, 2023 17:12
@joe-allen-89 @eleanor-heath
!type removed from return early.
5cccf4b 
Co-authored-by: Eleanor Taylor <61159216+eleanor-heath@users.noreply.github.com>
@joe-allen-89 @eleanor-heath
Shorten config ternary statement
576c17f 
Co-authored-by: Eleanor Taylor <61159216+eleanor-heath@users.noreply.github.com>
joe-replin
joe-replin approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@joe-replin joe-replin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in FF. Working as expected.

@joe-allen-89 joe-allen-89 merged commit e4f5761 into master Apr 21, 2023
@joe-allen-89 joe-allen-89 deleted the issue/91 branch April 21, 2023 08:24
github-actions bot pushed a commit that referenced this pull request Apr 21, 2023
@semantic-release-bot
Chore(release): 4.5.7 [skip ci]
62baf19 
## [4.5.7](v4.5.6...v4.5.7) (2023-04-21)

### Fix

* Check tutor type on page revisit before displaying inline feedback (fixes #91) (#92) ([e4f5761](e4f5761)), closes [#91](#91) [#92](#92)
github-actions bot pushed a commit to nagyist/adapt-contrib-tutor that referenced this pull request May 27, 2023
@semantic-release-bot
Chore(release): 2.2.0 [skip ci]
7679d6a 
# [2.2.0](v2.1.2...v2.2.0) (2023-05-27)

### chore

* added package.json ([677347b](677347b))
* added package.json ([94afb62](94afb62)), closes [#3072](https://github.com/nagyist/adapt-contrib-tutor/issues/3072)

### Fix

* _globals schema nesting (adaptlearning#90) ([c385e3c](c385e3c)), closes [adaptlearning#90](https://github.com/nagyist/adapt-contrib-tutor/issues/90)
* Added gitignore for release automation (adaptlearning#77) ([bef3c93](bef3c93)), closes [adaptlearning#77](https://github.com/nagyist/adapt-contrib-tutor/issues/77)
* Added release automation (adaptlearning#73) ([c04b610](c04b610)), closes [adaptlearning#73](https://github.com/nagyist/adapt-contrib-tutor/issues/73)
* Bump http-cache-semantics from 4.1.0 to 4.1.1 (adaptlearning#82) ([076e8c5](076e8c5)), closes [adaptlearning#82](https://github.com/nagyist/adapt-contrib-tutor/issues/82)
* Check tutor type on page revisit before displaying inline feedback (fixes adaptlearning#91) (adaptlearning#92) ([e4f5761](e4f5761)), closes [adaptlearning#91](https://github.com/nagyist/adapt-contrib-tutor/issues/91) [adaptlearning#92](https://github.com/nagyist/adapt-contrib-tutor/issues/92)
* Framework bumped to v5.22.8 ([8a17aae](8a17aae))
* Inline feedback normalisation across course and component config (fixes adaptlearning#87) (adaptlearning#88) ([f03b1ee](f03b1ee)), closes [adaptlearning#87](https://github.com/nagyist/adapt-contrib-tutor/issues/87) [adaptlearning#88](https://github.com/nagyist/adapt-contrib-tutor/issues/88)
* New style schema added. (adaptlearning#84) ([5be15e0](5be15e0)), closes [adaptlearning#84](https://github.com/nagyist/adapt-contrib-tutor/issues/84)
* Normalizing template icons ([cff3c07](cff3c07))
* replace deprecated a11y_attrs_heading usage (refs adaptlearning#67) (adaptlearning#76) ([f34b5fa](f34b5fa)), closes [adaptlearning#67](https://github.com/nagyist/adapt-contrib-tutor/issues/67) [adaptlearning#76](https://github.com/nagyist/adapt-contrib-tutor/issues/76)
* Stop _id property from directly rendering the _id view (adaptlearning#78) ([df1da66](df1da66)), closes [adaptlearning#78](https://github.com/nagyist/adapt-contrib-tutor/issues/78)
* Version numbers removed from Readme files ([7b6f5bd](7b6f5bd))

### New

* Issue and pr project addition automation (Fixes #3315) ([46f531d](46f531d)), closes [#3315](https://github.com/nagyist/adapt-contrib-tutor/issues/3315)
* Issue and pr project addition automation (refs adaptlearning/adapt_framework#3315) ([a666b69](a666b69))

### Update

* `"inline"` feedback restoration (adaptlearning#81) ([f5f35a2](f5f35a2)), closes [adaptlearning#81](https://github.com/nagyist/adapt-contrib-tutor/issues/81)
* Add accessible title (refs adaptlearning#74) (adaptlearning#75) ([bbe81f6](bbe81f6)), closes [adaptlearning#74](https://github.com/nagyist/adapt-contrib-tutor/issues/74) [adaptlearning#75](https://github.com/nagyist/adapt-contrib-tutor/issues/75)
* Switch to model.getFeedback allowing more complex feedback objects (adaptlearning#79) ([25fe47c](25fe47c)), closes [adaptlearning#79](https://github.com/nagyist/adapt-contrib-tutor/issues/79)

### Upgrade

* Bump yaml and semantic-release (adaptlearning#93) ([723a352](723a352)), closes [adaptlearning#93](https://github.com/nagyist/adapt-contrib-tutor/issues/93)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@joe-replin joe-replin joe-replin approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@guywillis guywillis guywillis approved these changes

@swashbuck swashbuck Awaiting requested review from swashbuck

@danielghost danielghost Awaiting requested review from danielghost

@cahirodoherty-learningpool cahirodoherty-learningpool Awaiting requested review from cahirodoherty-learningpool

@eleanor-heath eleanor-heath Awaiting requested review from eleanor-heath

Assignees

@joe-allen-89 joe-allen-89

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Completed question component feedback popups opening up on page load
6 participants
@joe-allen-89 @kirsty-hames @joe-replin @oliverfoster @guywillis @eleanor-heath