-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: Don't use markdown in the callout section #50437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @t-hamano 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Flaky tests detected in 8783f12. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4916745261
|
Related to: #50110, #50090
What?
This PR rewrites the markdown to an anchor element to ensure that the link in the callout section of the document displays correctly.
This PR rewrites the markdown to an anchor element to ensure that the link in the callout section of the document displays correctly.
https://developer.wordpress.org/block-editor/how-to-guides/themes/theme-json/#patterns
https://developer.wordpress.org/block-editor/reference-guides/packages/packages-blocks/
https://developer.wordpress.org/block-editor/reference-guides/packages/packages-e2e-test-utils-playwright/
Why?
As noted in this comment, if HTML is used within the callout section, it appears to display correctly. This PR uses the
a
andcode
elements, which also appear to be rendered correctly in the README on GitHub.