Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Formatting inside alert div #50090

Merged
merged 1 commit into from
Apr 26, 2023
Merged

[Docs] Formatting inside alert div #50090

merged 1 commit into from
Apr 26, 2023

Conversation

zzap
Copy link
Member

@zzap zzap commented Apr 26, 2023

Markdown inside alert div doesn't behave as the rest of the post content. It needs to be pure HTML for proper formatting.

Originally reported by @kdevnel in WordPress/Documentation-Issue-Tracker#796

The issue is in this section https://developer.wordpress.org/block-editor/reference-guides/packages/packages-env/#wp-env-run-container-command

What?

This PR is replacing markdown with HTML inside div.alert.

Why?

Notice divs in WordPress docs do not parse markdown. Pure HTML is required for proper formatting.

Screenshots or screencast

Before
before

After

after

Markdown inside alert div doesn't behave as the rest of the post content. It needs to be pure HTML for proper formatting.

Originally reported by @kdevnel in WordPress/Documentation-Issue-Tracker#796
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍪

@Mamaduka Mamaduka merged commit 9f7aef3 into WordPress:trunk Apr 26, 2023
@Mamaduka Mamaduka added the [Type] Developer Documentation Documentation for developers label Apr 26, 2023
@github-actions github-actions bot added this to the Gutenberg 15.7 milestone Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants