Doc: Block API > Registration: switch markdown to a-tags #50110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bph
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
|
apologies for the misleading branch name. should be docs/update-block-registration |
carolinan
reviewed
Apr 27, 2023
carolinan
reviewed
Apr 27, 2023
gziolo
approved these changes
Apr 27, 2023
|
Thanks @gziolo, as mentioned, it's just a theory, I am testing :-) It also seems there is one test failing, but also that it might not be connected to my PR. When you get a minute, could you help me figure out what the next steps are to get this merged? |
|
The failing test was unrelated, so I pushed the changes using my extended permissions 😅 |
|
Thank you! 🤗 |
|
I see now that links are broken, so we probably need also to use full URLs here or tweak the processing for the handbook page that happens for the developer portal. |
|
I also found the links nor working. I try to figure out what the right link would be in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
fixes #50109
Why?
in
<div callouts>Links need to be a-tags instead of MarkdownThat is only a theory, I am testing. I have not found any information in that regard in the documentation.
How?
switch markdown to a-tags