Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Add instructions to use HTML links inside callouts #50125

Closed
bph opened this issue Apr 27, 2023 · 0 comments · Fixed by #50131
Closed

Doc: Add instructions to use HTML links inside callouts #50125

bph opened this issue Apr 27, 2023 · 0 comments · Fixed by #50131
Assignees
Labels
[Type] Developer Documentation Documentation for developers

Comments

@bph
Copy link
Contributor

bph commented Apr 27, 2023

As a follow up on #50110 that fixed #50109 - the contributor handbook (block editor) needs an update.
Section to update: Documentation Contributions > Callout notices

To add a comment that without the div tags, Markdown links don't work, but

Also the page needs to updated again as the parser didn't do the 'normal' link parsing.

https://developer.wordpress.org/docs/reference-guides/block-api/block-metadata.md
Should have been converted to
https://developer.wordpress.org/block-editor/reference-guides/block-api/block-metadata/

And https://developer.wordpress.org/docs/getting-started/create-block/README.md
Should be https://developer.wordpress.org/block-editor/getting-started/create-block/

I am uncertain if that is expected or a bug in the link parser...

It definitely needs to be fixed on the modified page, though.

Step-by-step reproduction instructions

Got to https://developer.wordpress.org/block-editor/reference-guides/block-api/block-registration/
Follow the links in the yellow call out box.
They all 404.

Screenshots, screen recording, code snippet

Screenshot 2023-04-27 at 12 52 53

@bph bph self-assigned this Apr 27, 2023
@bph bph added the [Type] Developer Documentation Documentation for developers label Apr 27, 2023
bph added a commit that referenced this issue Apr 27, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 27, 2023
bph added a commit that referenced this issue Apr 28, 2023
* Fixes #50125
* HTML encoding needed
* add call out to the link section, too.
* use absolute URLs instead

Props to @gziolo
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants