feat: part 1 native currency routing support by removing .wrapped in implementation classes #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…implementation classes
Graphite Automations"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (09/30/24)3 reviewers were added and 1 assignee was added to this PR based on 's automation. |
This was referenced Sep 30, 2024
cgkol
approved these changes
Sep 30, 2024
jsy1218
deleted the
siyujiang/native-currency-routing-remove-wrapped
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
there are several code places where we simply wrap the currency, and thus not able to support native currency routing in v4.
What is the new behavior (if this is a feature change)?
we are removing the .wrapped implementations. We keep the alpha router to pass in the wrapped tokens into the quoters in this PR, for backward compatibility.
Other information:
re-do feat(breaking): top-level alpha router native currencyIn, currencyIn, quoteCurrency support #715 with breakdowns