-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: part 2 alpha router pass down currencyIn currencyOut #724
Merged
jsy1218
merged 4 commits into
main
from
siyujiang/alpha-router-pass-down-currencyIn-currencyOut
Sep 30, 2024
Merged
feat: part 2 alpha router pass down currencyIn currencyOut #724
jsy1218
merged 4 commits into
main
from
siyujiang/alpha-router-pass-down-currencyIn-currencyOut
Sep 30, 2024
+56
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 30, 2024
cgkol
approved these changes
Sep 30, 2024
Base automatically changed from
siyujiang/native-currency-routing-remove-wrapped
to
main
September 30, 2024 15:54
jsy1218
deleted the
siyujiang/alpha-router-pass-down-currencyIn-currencyOut
branch
September 30, 2024 17:52
Graphite Automations"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (09/30/24)4 reviewers were added and 1 assignee was added to this PR based on 's automation. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
alpha router passes down the wrapped tokenIn and tokenOut
What is the new behavior (if this is a feature change)?
alpha router will pass down the currencyIn and currencyOut, so that v4 native currency routing can be supported.
Other information: