feat(breaking): top-level alpha router native currencyIn, currencyIn, quoteCurrency support #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (09/23/24)3 reviewers were added and 1 assignee was added to this PR based on 's automation. |
xrsv
approved these changes
Sep 23, 2024
jsy1218
force-pushed
the
siyujiang/route-290-top-level-alpha-router-native-currencyin-currencyin
branch
from
c745fdc
to
f9f1901
Compare
jsy1218
deleted the
siyujiang/route-290-top-level-alpha-router-native-currencyin-currencyin
branch
Merged
This was referenced Sep 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
breaking feature
What is the current behavior? (You can also link to an open issue here)
Top-level alpha router doesn't support native currency routing.
What is the new behavior (if this is a feature change)?
Top-level alpha router should support native currency routing.
Other information:
breaking because I changed the method name in CachedRoute class. Will have to major version bump SOR.