Remove timestamp from share url for all services except youtube #5228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiangRongLin
requested changes
Dec 20, 2020
app/src/main/java/org/schabi/newpipe/player/VideoPlayerImpl.java
Outdated
Show resolved
Hide resolved
It produces not found error for PeerTube, media.ccc.de, SoundCloud
|
PeerTube sharing works like this https://framatube.org/videos/watch/9c9de5e8-0a1e-484a-b099-e80766180a6d?start=1m32s |
B0pol
added
bug
|
@TobiGr please read the pr description |
|
@TobiGr that should be handled extractor-side, this is just a (hopefully temporary) workaround, so it shouldn't include timestamp share for all services |
|
I read the PR description. But why only fix the bug for YouTube and not for other services as well? |
|
@Stypox you are right, so that it doesn't break URLs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Remove timestamp from share url unless it's youtube.
It produced not found error for PeerTube, media.ccc.de, SoundCloud.
Ideally we should implement this
#4316 (comment)
but it has been three months and no one is willing to work on this, then I'd like to get this PR merged for the next release.
Fixes the following issue(s)
APK testing
app-debug.zip
Due diligence