Skip to content

Commit

Permalink
remove timestamp from share url for all services except youtube
Browse files Browse the repository at this point in the history
It produces not found error for PeerTube, media.ccc.de, SoundCloud
  • Loading branch information
B0pol committed Dec 20, 2020
1 parent 2880280 commit b2b25db
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions app/src/main/java/org/schabi/newpipe/player/VideoPlayerImpl.java
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@

import java.util.List;

import static org.schabi.newpipe.extractor.ServiceList.YouTube;
import static org.schabi.newpipe.player.MainPlayer.ACTION_CLOSE;
import static org.schabi.newpipe.player.MainPlayer.ACTION_FAST_FORWARD;
import static org.schabi.newpipe.player.MainPlayer.ACTION_FAST_REWIND;
Expand Down Expand Up @@ -889,10 +890,17 @@ private void onMoreOptionsClicked() {
private void onShareClicked() {
// share video at the current time (youtube.com/watch?v=ID&t=SECONDS)
// Timestamp doesn't make sense in a live stream so drop it
final String ts = isLive() ? "" : ("&t=" + (getPlaybackSeekBar().getProgress() / 1000));

final int ts = getPlaybackSeekBar().getProgress() / 1000;
final MediaSourceTag metadata = getCurrentMetadata();
String videoUrl = getVideoUrl();
if (!isLive() && metadata != null
&& metadata.getMetadata().getServiceId() == YouTube.getServiceId() && ts >= 0) {
videoUrl += ("&t=" + ts);
}
ShareUtils.shareUrl(service,
getVideoTitle(),
getVideoUrl() + ts);
videoUrl);
}

private void onPlayWithKodiClicked() {
Expand Down

0 comments on commit b2b25db

Please sign in to comment.