Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.20.7 #5245

Closed
4 of 5 tasks
TobiGr opened this issue Dec 21, 2020 · 18 comments · Fixed by #5259
Closed
4 of 5 tasks

Release 0.20.7 #5245

TobiGr opened this issue Dec 21, 2020 · 18 comments · Fixed by #5259

Comments

@TobiGr
Copy link
Member

TobiGr commented Dec 21, 2020

Changelogs

App

New

Improved

Fixed

Development

Extractor

New

Improved

Fixed

Development

To do

APK for testing

NewPipe_v0.20.7_RC5.zip

See the corresponding PR #5246

@TobiGr TobiGr mentioned this issue Dec 21, 2020
6 tasks
@triallax triallax pinned this issue Dec 22, 2020
@Poolitzer
Copy link
Member

Poolitzer commented Dec 22, 2020

Accessing the player queue via notification when the player is in the background opens the correct view, but nothing is enqueued/the player is not accessible.

@Orion983
Copy link

Ooh nice! Finally i can use mixes! When is the full release of this version?

@Orion983
Copy link

And my youtube chapters/segnests! Thanks for adding my idea!

@XiangRongLin
Copy link
Collaborator

@TobiGr You need to replace the extractor links. They are currently pointing to this repo

@TobiGr
Copy link
Member Author

TobiGr commented Dec 22, 2020

The problem described by @Poolitzer was caused by e602146. @Isira-Seneviratne Do you have time for fixing this?

@XiangRongLin Fixed.

@agravier
Copy link

Opened the RC1, tried to play https://www.youtube.com/watch?v=-cf5CGYjGt4 from the search, raised an exception as follows:

(The music still plays)

Exception

  • User Action: ui error
  • Request: App crash, UI failure
  • Content Country: GB
  • Content Language: en
  • App Language: en_US
  • Service: none
  • Version: 0.20.1
  • OS: Linux Android 11 - 30
Crash log

java.lang.RuntimeException: Error receiving broadcast Intent { act=org.schabi.newpipe.VideoDetailFragment.ACTION_PLAYER_STARTED flg=0x10 } in org.schabi.newpipe.fragments.detail.VideoDetailFragment$4@6fa63fa
	at android.app.LoadedApk$ReceiverDispatcher$Args.lambda$getRunnable$0$LoadedApk$ReceiverDispatcher$Args(LoadedApk.java:1590)
	at android.app.-$$Lambda$LoadedApk$ReceiverDispatcher$Args$_BumDX2UKsnxLVrE6UJsJZkotuA.run(Unknown Source:2)
	at android.os.Handler.handleCallback(Handler.java:938)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:223)
	at android.app.ActivityThread.main(ActivityThread.java:7660)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
Caused by: java.lang.IllegalStateException: Not allowed to start service Intent { cmp=org.schabi.newpipe/.player.MainPlayer }: app is in background uid UidRecord{4a715eb u0a394 CAC  bg:+2m19s320ms idle procs:1 seq(0,0,0)}
	at android.app.ContextImpl.startServiceCommon(ContextImpl.java:1715)
	at android.app.ContextImpl.startService(ContextImpl.java:1670)
	at android.content.ContextWrapper.startService(ContextWrapper.java:720)
	at org.schabi.newpipe.player.helper.PlayerHolder.startService(PlayerHolder.java:59)
	at org.schabi.newpipe.fragments.detail.VideoDetailFragment$4.onReceive(VideoDetailFragment.java:1343)
	at android.app.LoadedApk$ReceiverDispatcher$Args.lambda$getRunnable$0$LoadedApk$ReceiverDispatcher$Args(LoadedApk.java:1580)
	... 8 more


@Isira-Seneviratne
Copy link
Member

Isira-Seneviratne commented Dec 23, 2020

The problem described by @Poolitzer was caused by e602146. @Isira-Seneviratne Do you have time for fixing this?

@XiangRongLin Fixed.

I'll do it in a few hours.

I'm not sure what's causing the issue, since I made sure to keep the logic the same.

@Stypox did you come across this issue?

@Stypox
Copy link
Member

Stypox commented Dec 23, 2020

@Isira-Seneviratne I could reproduce, but didn't come across this issue while testing

@agravier that's caused by the interactions of multiple NewPipes and is not related to this release

@vkay94
Copy link
Contributor

vkay94 commented Dec 23, 2020

I'm not sure what's causing the issue, since I made sure to keep the logic the same.

Yeah, that's pretty strange, especially the fact that the layout is showing correctly for a moment and disappears again ...

@TobiGr
Copy link
Member Author

TobiGr commented Dec 23, 2020

NewPipe_v0.20.7_RC2.zip contains:

  • translation updates
  • stream and search meta info (public broadcasters and Covid-19)
  • ktlint update

@Isira-Seneviratne
Copy link
Member

@Stypox I fixed the issue.

@TobiGr TobiGr reopened this Dec 23, 2020
@TobiGr
Copy link
Member Author

TobiGr commented Dec 23, 2020

NewPipe_v0.20.7_RC3.zip contains @Isira-Seneviratne's fix for the empty play queue

@B0pol
Copy link
Member

B0pol commented Dec 23, 2020

@Isira-Seneviratne I could reproduce, but didn't come across this issue while testing

@agravier that's caused by the interactions of multiple NewPipes and is not related to this release

and is fixed by #5221, hopefully in the next update

@TobiGr
Copy link
Member Author

TobiGr commented Dec 23, 2020

NewPipe_v0.20.7_RC4.zip fixes media.ccc.de's service color and adds Somali to the app language chooser.

The changelog for this release is ready to be translated on weblate: https://hosted.weblate.org/projects/newpipe/metadata/

@B0pol
Copy link
Member

B0pol commented Dec 23, 2020

Regression:

Exception

Crash log

org.schabi.newpipe.extractor.exceptions.ParsingException: Got HTML document, expected JSON response (latest url was: "https://www.youtube.com/watch?v=CLAK5uy_l5C")
	at org.schabi.newpipe.extractor.services.youtube.YoutubeParsingHelper.getValidJsonResponseBody(YoutubeParsingHelper.java:575)
	at org.schabi.newpipe.extractor.services.youtube.YoutubeParsingHelper.getResponse(YoutubeParsingHelper.java:588)
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeMixPlaylistExtractor.onFetchPage(YoutubeMixPlaylistExtractor.java:59)
	at org.schabi.newpipe.extractor.Extractor.fetchPage(Extractor.java:54)
	at org.schabi.newpipe.extractor.playlist.PlaylistInfo.getInfo(PlaylistInfo.java:30)
	at org.schabi.newpipe.util.ExtractorHelper.lambda$getPlaylistInfo$9(ExtractorHelper.java:172)
	at org.schabi.newpipe.util.-$$Lambda$ExtractorHelper$RLOrwix0kCDfcc_WpFBc8DTJw0Q.call(Unknown Source:4)
	at io.reactivex.rxjava3.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:43)
	at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4813)
	at io.reactivex.rxjava3.internal.operators.single.SingleDoOnSuccess.subscribeActual(SingleDoOnSuccess.java:35)
	at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4813)
	at io.reactivex.rxjava3.internal.operators.maybe.MaybeFromSingle.subscribeActual(MaybeFromSingle.java:41)
	at io.reactivex.rxjava3.core.Maybe.subscribe(Maybe.java:5330)
	at io.reactivex.rxjava3.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.drain(MaybeConcatArray.java:153)
	at io.reactivex.rxjava3.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.request(MaybeConcatArray.java:78)
	at io.reactivex.rxjava3.internal.operators.flowable.FlowableElementAtMaybe$ElementAtSubscriber.onSubscribe(FlowableElementAtMaybe.java:66)
	at io.reactivex.rxjava3.internal.operators.maybe.MaybeConcatArray.subscribeActual(MaybeConcatArray.java:42)
	at io.reactivex.rxjava3.core.Flowable.subscribe(Flowable.java:15753)
	at io.reactivex.rxjava3.internal.operators.flowable.FlowableElementAtMaybe.subscribeActual(FlowableElementAtMaybe.java:36)
	at io.reactivex.rxjava3.core.Maybe.subscribe(Maybe.java:5330)
	at io.reactivex.rxjava3.internal.operators.maybe.MaybeToSingle.subscribeActual(MaybeToSingle.java:46)
	at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4813)
	at io.reactivex.rxjava3.internal.operators.single.SingleSubscribeOn$SubscribeOnObserver.run(SingleSubscribeOn.java:89)
	at io.reactivex.rxjava3.core.Scheduler$DisposeTask.run(Scheduler.java:614)
	at io.reactivex.rxjava3.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:65)
	at io.reactivex.rxjava3.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:56)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	at java.lang.Thread.run(Thread.java:764)


@TobiGr
Copy link
Member Author

TobiGr commented Dec 23, 2020

Regression will be fixed by TeamNewPipe/NewPipeExtractor#484

@kubo6472 kubo6472 mentioned this issue Dec 24, 2020
4 tasks
@Poolitzer
Copy link
Member

blogpost can be found at TeamNewPipe/website#211

@TobiGr
Copy link
Member Author

TobiGr commented Dec 25, 2020

Last RC containing the fix for YouTube Music search and a fixed regression for YouTube Music Playlists
NewPipe_v0.20.7_RC5.zip

@Stypox Stypox closed this as completed Dec 26, 2020
@B0pol B0pol unpinned this issue Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants