Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A small part of the sidebar is in the status bar #2810

Closed
ghost opened this issue Nov 17, 2019 · 4 comments
Closed

A small part of the sidebar is in the status bar #2810

ghost opened this issue Nov 17, 2019 · 4 comments
Labels
bug Issue is related to a bug good first issue Easy/simple issues perfect for newcomers to get involved in the project GUI Issue is related to the graphical user interface

Comments

@ghost
Copy link

ghost commented Nov 17, 2019 •
edited by ghost
Loading

Hi,

when I open the sidebar under Android 7 in the NewPipe app (0.17.4). You can see a small part of the sidebar in the status bar.

20191117_134543

I've seen friends using a much bigger Android phone (Samsung Galaxy S10+ - Android 9) that even the "NewPipe logo + NewPipe" in the sidebar is almost in the status bar and it doesn't look right anymore.
@Stypox Stypox added bug Issue is related to a bug GUI Issue is related to the graphical user interface good first issue Easy/simple issues perfect for newcomers to get involved in the project labels Dec 3, 2019
hemilpanchiwala added a commit to hemilpanchiwala/NewPipe that referenced this issue Dec 5, 2019
@hemilpanchiwala
Solving issue TeamNewPipe#2810 by changing drawer_layout.xml
506d155
@hemilpanchiwala hemilpanchiwala mentioned this issue Dec 5, 2019
Closed
1 task
@TobiGr
Copy link
Member

TobiGr commented Dec 6, 2019

The navigation drawer should be under the status bar as you can read and see here in the material guidelines.

I've seen friends using a much bigger Android phone (Samsung Galaxy S10+ - Android 9) that even the "NewPipe logo + NewPipe" in the sidebar is almost in the status bar and it doesn't look right anymore.

This needs to be addressed, though.

@Stypox
Copy link
Member

Stypox commented Apr 2, 2020

@mauriciocolli since you messed with the drawer layout in #3259, do you have any idea how this could be solved? Image for reference:

@mauriciocolli
Copy link
Contributor

@Stypox should be fixed in #3334.

@TobiGr
Copy link
Member

TobiGr commented Apr 2, 2020

Fixed in #3334

@TobiGr TobiGr closed this as completed Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue is related to a bug good first issue Easy/simple issues perfect for newcomers to get involved in the project GUI Issue is related to the graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Solving issue #2810 by changing drawer_layout.xml hemilpanchiwala/NewPipe
3 participants
@mauriciocolli @TobiGr @Stypox