Use ActivityCompat.recreate(). #5178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stypox
requested changes
Dec 15, 2020
| @@ -31,7 +32,7 @@ public boolean onPreferenceChange(final Preference preference, final Object newV | |||
|
|
|||
| if (!newValue.equals(startThemeKey) && getActivity() != null) { | |||
| // If it's not the current theme | |||
| getActivity().recreate(); | |||
| ActivityCompat.recreate(requireActivity()); | |||
There was a problem hiding this comment.
Isn't recreate() also begin used in ServicePlayerActivity and MainActivity?
There was a problem hiding this comment.
This was the only usage of recreate I found.
Edit: I found those usages you mentioned.
Isira-Seneviratne
force-pushed
the
Use_ActivityCompat_recreate
branch
from
cb1b7c5
to
807e4d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
ActivityCompat.recreate()to work around bugs in the platformrecreatemethod on API levels below 28.APK testing
debug.zip
Due diligence