Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SkeletonThumbnail][SkeletonPage] Consolidate se23 conditional logic #10143

Merged
merged 1 commit into from
Aug 25, 2023
Merged

[SkeletonThumbnail][SkeletonPage] Consolidate se23 conditional logic #10143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions polaris-react/src/components/SkeletonPage/SkeletonPage.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,9 @@ $primary-action-button-width: 6.25rem;
}

.Title {
font-weight: var(--p-font-weight-semibold);
font-weight: var(--p-font-weight-bold);
font-size: var(--p-font-size-300);
line-height: var(--p-font-line-height-4);

#{$se23} & {
font-weight: var(--p-font-weight-bold);
}
}

.SkeletonTitle {
Expand Down
14 changes: 3 additions & 11 deletions polaris-react/src/components/SkeletonThumbnail/SkeletonThumbnail.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,14 @@

.SkeletonThumbnail {
// stylelint-disable -- Polaris component custom properties
--pc-skeleton-thumbnail-extra-small-size: 24px;
--pc-skeleton-thumbnail-small-size: 40px;
--pc-skeleton-thumbnail-extra-small-size: 40px;
--pc-skeleton-thumbnail-small-size: 48px;
--pc-skeleton-thumbnail-medium-size: 60px;
--pc-skeleton-thumbnail-large-size: 80px;
// stylelint-enable
display: flex;
background-color: var(--p-color-bg-strong);
border-radius: var(--p-border-radius-1);

#{$se23} & {
// stylelint-disable -- Polaris component custom properties, se23 temporary styles
--pc-skeleton-thumbnail-extra-small-size: 40px;
--pc-skeleton-thumbnail-small-size: 48px;
// stylelint-enable
border-radius: var(--p-border-radius-2);
}
border-radius: var(--p-border-radius-2);

@media screen and (-ms-high-contrast: active) {
background-color: grayText;
Expand Down
Loading